Skip to content

fix: button text for file-select slot can now be customized#1252

Merged
luwes merged 5 commits intomuxinc:mainfrom
Pintorado:fix-file-select-slot-content
Dec 4, 2025
Merged

fix: button text for file-select slot can now be customized#1252
luwes merged 5 commits intomuxinc:mainfrom
Pintorado:fix-file-select-slot-content

Conversation

@Pintorado
Copy link
Contributor

@Pintorado Pintorado commented Dec 3, 2025 •
edited
Loading

Changes

  • Prevent translating the text if the file picker button is a custom one.
  • Added a test for this case

@Pintorado Pintorado requested a review from a team as a code owner December 3, 2025 16:46
@vercel
Copy link

vercel bot commented Dec 3, 2025

@Pintorado is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@snyk-io
Copy link

snyk-io bot commented Dec 3, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

luwes
luwes reviewed Dec 3, 2025
View reviewed changes
packages/mux-uploader/src/mux-uploader-file-select.ts Outdated
Comment on lines 160 to 172
Copy link
Contributor

@luwes luwes Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be simplified if you keep the code in the else block.

Suggested change
const buttonEl = this.shadowRoot?.querySelector('#file-select') as HTMLButtonElement;
if (buttonEl) {
buttonEl.textContent = text;
}

luwes
luwes approved these changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vercel
Copy link

vercel bot commented Dec 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
elements-demo-vue Ready Ready Preview Comment Dec 4, 2025 2:45pm

@luwes luwes merged commit 240d2ae into muxinc:main Dec 4, 2025
7 of 11 checks passed
@github-actions github-actions bot mentioned this pull request Dec 3, 2025
Merged
luwes pushed a commit that referenced this pull request Dec 4, 2025
@github-actions
chore: release main (#1250)
8dd92b7 
🤖 I have created a release *beep* *boop*
---


<details><summary>@mux/mux-audio: 0.15.17</summary>

##
[0.15.17](https://github.com/muxinc/elements/compare/@mux/mux-audio@0.15.16...@mux/mux-audio@0.15.17)
(2025-12-04)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.31.4 to 0.32.0
</details>

<details><summary>@mux/mux-audio-react: 0.15.17</summary>

##
[0.15.17](https://github.com/muxinc/elements/compare/@mux/mux-audio-react@0.15.16...@mux/mux-audio-react@0.15.17)
(2025-12-04)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.31.4 to 0.32.0
</details>

<details><summary>@mux/playback-core: 0.32.0</summary>

##
[0.32.0](https://github.com/muxinc/elements/compare/@mux/playback-core@0.31.4...@mux/playback-core@0.32.0)
(2025-12-04)


### Features

* add `max-auto-resolution` attribute for automatic resolution capping
([#1243](#1243))
([a43edd5](a43edd5))


### Bug Fixes

* Properly setup DRM to support Airplay
([#1245](#1245))
([673b7ff](673b7ff))
</details>

<details><summary>@mux/mux-player: 3.10.0</summary>

##
[3.10.0](https://github.com/muxinc/elements/compare/@mux/mux-player@3.9.2...@mux/mux-player@3.10.0)
(2025-12-04)


### Features

* add `max-auto-resolution` attribute for automatic resolution capping
([#1243](#1243))
([a43edd5](a43edd5))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/mux-video bumped from 0.28.2 to 0.29.0
    * @mux/playback-core bumped from 0.31.4 to 0.32.0
</details>

<details><summary>@mux/mux-player-astro: 3.10.0</summary>

##
[3.10.0](https://github.com/muxinc/elements/compare/@mux/mux-player-astro@3.9.2...@mux/mux-player-astro@3.10.0)
(2025-12-04)


### Miscellaneous Chores

* **@mux/mux-player-astro:** Synchronize player versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/mux-player bumped from 3.9.2 to 3.10.0
    * @mux/playback-core bumped from 0.31.4 to 0.32.0
</details>

<details><summary>@mux/mux-player-react: 3.10.0</summary>

##
[3.10.0](https://github.com/muxinc/elements/compare/@mux/mux-player-react@3.9.2...@mux/mux-player-react@3.10.0)
(2025-12-04)


### Features

* add `max-auto-resolution` attribute for automatic resolution capping
([#1243](#1243))
([a43edd5](a43edd5))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/mux-player bumped from 3.9.2 to 3.10.0
    * @mux/playback-core bumped from 0.31.4 to 0.32.0
</details>

<details><summary>@mux/mux-video: 0.29.0</summary>

##
[0.29.0](https://github.com/muxinc/elements/compare/@mux/mux-video@0.28.2...@mux/mux-video@0.29.0)
(2025-12-04)


### Features

* add `max-auto-resolution` attribute for automatic resolution capping
([#1243](#1243))
([a43edd5](a43edd5))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.31.4 to 0.32.0
</details>

<details><summary>@mux/mux-video-react: 0.29.0</summary>

##
[0.29.0](https://github.com/muxinc/elements/compare/@mux/mux-video-react@0.28.2...@mux/mux-video-react@0.29.0)
(2025-12-04)


### Miscellaneous Chores

* **@mux/mux-video-react:** Synchronize video versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.31.4 to 0.32.0
</details>

<details><summary>@mux/mux-uploader: 1.4.1</summary>

##
[1.4.1](https://github.com/muxinc/elements/compare/@mux/mux-uploader@1.4.0...@mux/mux-uploader@1.4.1)
(2025-12-04)


### Bug Fixes

* button text for file-select slot can now be customized
([#1252](#1252))
([240d2ae](240d2ae))
</details>

<details><summary>@mux/mux-uploader-astro: 1.4.1</summary>

##
[1.4.1](https://github.com/muxinc/elements/compare/@mux/mux-uploader-astro@1.4.0...@mux/mux-uploader-astro@1.4.1)
(2025-12-04)


### Miscellaneous Chores

* **@mux/mux-uploader-astro:** Synchronize uploader versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/mux-uploader bumped from 1.4.0 to 1.4.1
</details>

<details><summary>@mux/mux-uploader-react: 1.4.1</summary>

##
[1.4.1](https://github.com/muxinc/elements/compare/@mux/mux-uploader-react@1.4.0...@mux/mux-uploader-react@1.4.1)
(2025-12-04)


### Miscellaneous Chores

* **@mux/mux-uploader-react:** Synchronize uploader versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/mux-uploader bumped from 1.4.0 to 1.4.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luwes luwes luwes approved these changes

@Jerricho93 Jerricho93 Jerricho93 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pintorado @luwes @Jerricho93