Skip to content

Fix/default hidden captions native hls#1258

Closed
ronalduQualabs wants to merge 8 commits intomuxinc:mainfrom
ronalduQualabs:fix/default-hidden-captions-native-hls
Closed

Fix/default hidden captions native hls#1258
ronalduQualabs wants to merge 8 commits intomuxinc:mainfrom
ronalduQualabs:fix/default-hidden-captions-native-hls

Conversation

@ronalduQualabs
Copy link
Contributor

This change resolve 1160 fixing default-hidden-captions behavior when using native HLS (Safari).

This add listens for addtrack events and explicitly disables newly added
text tracks when the default-hidden-captions attribute is present.

@ronalduQualabs ronalduQualabs requested a review from a team as a code owner December 16, 2025 16:37
@vercel
Copy link

vercel bot commented Dec 16, 2025

@ronalduQualabs is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@snyk-io
Copy link

snyk-io bot commented Dec 16, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.49%. Comparing base (d41c5e7) to head (4398c33).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1258      +/-   ##
==========================================
+ Coverage   70.73%   71.49%   +0.75%     
==========================================
  Files          37       45       +8     
  Lines        6677     7118     +441     
  Branches      498      526      +28     
==========================================
+ Hits         4723     5089     +366     
- Misses       1951     2026      +75     
  Partials        3        3              

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Unable to hide captions by default in Safari on iPhone

1 participant