feat: implement Mux badge by davekiss · Pull Request #988 · muxinc/elements

davekiss · 2024-09-19T19:05:53Z

Adds proudly-display-mux-badge attribute to render a linkback to Mux

See the bottom player in the example deployment: https://elements-demo-vanilla-git-fork-davekiss-dk-powered-by-mux.vercel.app/mux-player.html

vercel · 2024-09-19T19:05:59Z

@davekiss is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

dylanjha · 2024-09-19T19:28:17Z

Such a good idea!

vercel · 2024-09-19T19:57:05Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
elements-demo-astro	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 13, 2025 6:08pm
elements-demo-create-react-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 13, 2025 6:08pm
elements-demo-nextjs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 13, 2025 6:08pm
elements-demo-svelte-kit	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 13, 2025 6:08pm
elements-demo-vanilla	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 13, 2025 6:08pm
elements-demo-vue	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 13, 2025 6:08pm

codecov · 2024-09-21T12:17:50Z

Codecov Report

Attention: Patch coverage is 91.26984% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.68%. Comparing base (76aa003) to head (eadc94c).
Report is 51 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/mux-player/src/index.ts	38.88%	11 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
- Coverage   81.67%   80.68%   -0.99%     
==========================================
  Files          40       41       +1     
  Lines        8571     9711    +1140     
  Branches      470      504      +34     
==========================================
+ Hits         7000     7835     +835     
- Misses       1565     1876     +311     
+ Partials        6        0       -6

Flag	Coverage Δ
	`80.68% <91.26%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/mux-player/src/template.ts	`94.67% <100.00%> (-0.27%)`	⬇️
packages/mux-player/src/themes/gerwig/gerwig.html	`100.00% <100.00%> (ø)`
packages/mux-player/src/index.ts	`72.98% <38.88%> (+0.42%)`	⬆️

... and 17 files with indirect coverage changes

packages/mux-player/REFERENCE.md

examples/nextjs-with-typescript/pages/MuxPlayer.tsx

cjpillsbury · 2025-01-07T22:58:57Z

issue(blocking): still not seeing the badge here: https://elements-demo-nextjs-git-fork-davekiss-dk-powered-by-mux.vercel.app/MuxPlayer?playbackId=%22a4nOgmxGWg6gULfcBbAa00gXyfcwPnAFldF8RdsNyk8M%22&title=%22Landscape+VOD%22&proudlyDisplayMuxBadge=true&muted=true&autoPlay=true

cjpillsbury

looks like there's still some lingering issues here

davekiss · 2025-01-08T12:22:08Z

@cjpillsbury turns out the BooleanRenderer is required for the URL query param to work

cjpillsbury · 2025-01-08T17:19:08Z

Still not working right. Prop is properly getting passed down as an attr to the <mux-player> web component but not getting set on the template. I can look into this if needed.

notion-workspace · 2025-01-09T20:49:40Z

Ship Mux Player badge

packages/mux-player/src/index.ts

packages/mux-player/src/themes/gerwig/gerwig.html

packages/mux-player/src/index.ts

Co-authored-by: Wesley Luyten <me@wesleyluyten.com>

luwes

LGTM!
make sure tests pass

🤖 I have created a release *beep* *boop* --- <details><summary>@mux/mux-active-viewer-count: 0.2.0-alpha.12</summary> ## [0.2.0-alpha.12](https://github.com/muxinc/elements/compare/@mux/mux-active-viewer-count@0.2.0-alpha.11...@mux/mux-active-viewer-count@0.2.0-alpha.12) (2025-02-13) ### Bug Fixes * upgrade MC, fix theme flicker ([#1067](#1067)) ([b2fad06](b2fad06)) </details> <details><summary>@mux/playback-core: 0.28.3</summary> ## [0.28.3](https://github.com/muxinc/elements/compare/@mux/playback-core@0.28.2...@mux/playback-core@0.28.3) (2025-02-13) ### Bug Fixes * **playback-core:** Update hls.js version to fix multi-DRM playready bug. ([#1060](#1060)) ([380ded2](380ded2)) * upgrade MC, fix theme flicker ([#1067](#1067)) ([b2fad06](b2fad06)) </details> <details><summary>@mux/mux-player: 3.3.0</summary> ## [3.3.0](https://github.com/muxinc/elements/compare/@mux/mux-player@3.2.4...@mux/mux-player@3.3.0) (2025-02-13) ### Features * implement Mux badge ([#988](#988)) ([2343df8](2343df8)) ### Bug Fixes * add missing menu part ([#1066](#1066)) ([f5c6d90](f5c6d90)), closes [#1065](#1065) * Mux-player imports ([#1056](#1056)) ([9b7ec1b](9b7ec1b)) * **playback-core:** Update hls.js version to fix multi-DRM playready bug. ([#1060](#1060)) ([380ded2](380ded2)) * upgrade MC, fix theme flicker ([#1067](#1067)) ([b2fad06](b2fad06)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-video bumped from 0.24.2 to 0.24.3 * @mux/playback-core bumped from 0.28.2 to 0.28.3 </details> <details><summary>@mux/mux-player-react: 3.3.0</summary> ## [3.3.0](https://github.com/muxinc/elements/compare/@mux/mux-player-react@3.2.4...@mux/mux-player-react@3.3.0) (2025-02-13) ### Features * implement Mux badge ([#988](#988)) ([2343df8](2343df8)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-player bumped from 3.2.4 to 3.3.0 * @mux/playback-core bumped from 0.28.2 to 0.28.3 </details> <details><summary>@mux/mux-audio: 0.15.3</summary> ## [0.15.3](https://github.com/muxinc/elements/compare/@mux/mux-audio@0.15.2...@mux/mux-audio@0.15.3) (2025-02-13) ### Bug Fixes * **playback-core:** Update hls.js version to fix multi-DRM playready bug. ([#1060](#1060)) ([380ded2](380ded2)) * upgrade MC, fix theme flicker ([#1067](#1067)) ([b2fad06](b2fad06)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.28.2 to 0.28.3 </details> <details><summary>@mux/mux-audio-react: 0.15.3</summary> ## [0.15.3](https://github.com/muxinc/elements/compare/@mux/mux-audio-react@0.15.2...@mux/mux-audio-react@0.15.3) (2025-02-13) ### Miscellaneous Chores * **@mux/mux-audio-react:** Synchronize audio versions ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.28.2 to 0.28.3 </details> <details><summary>@mux/mux-video: 0.24.3</summary> ## [0.24.3](https://github.com/muxinc/elements/compare/@mux/mux-video@0.24.2...@mux/mux-video@0.24.3) (2025-02-13) ### Bug Fixes * **playback-core:** Update hls.js version to fix multi-DRM playready bug. ([#1060](#1060)) ([380ded2](380ded2)) * upgrade MC, fix theme flicker ([#1067](#1067)) ([b2fad06](b2fad06)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.28.2 to 0.28.3 </details> <details><summary>@mux/mux-video-react: 0.24.3</summary> ## [0.24.3](https://github.com/muxinc/elements/compare/@mux/mux-video-react@0.24.2...@mux/mux-video-react@0.24.3) (2025-02-13) ### Miscellaneous Chores * **@mux/mux-video-react:** Synchronize video versions ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.28.2 to 0.28.3 </details> <details><summary>@mux/mux-uploader: 1.1.2</summary> ## [1.1.2](https://github.com/muxinc/elements/compare/@mux/mux-uploader@1.1.1...@mux/mux-uploader@1.1.2) (2025-02-13) ### Bug Fixes * upgrade MC, fix theme flicker ([#1067](#1067)) ([b2fad06](b2fad06)) </details> <details><summary>@mux/mux-uploader-react: 1.1.2</summary> ## [1.1.2](https://github.com/muxinc/elements/compare/@mux/mux-uploader-react@1.1.1...@mux/mux-uploader-react@1.1.2) (2025-02-13) ### Miscellaneous Chores * **@mux/mux-uploader-react:** Synchronize uploader versions ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-uploader bumped from 1.1.1 to 1.1.2 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

feat: implement Mux badge

97ac204

davekiss requested a review from a team as a code owner September 19, 2024 19:05

vercel bot deployed to Preview – elements-demo-vanilla September 19, 2024 19:57 View deployment

Merge branch 'main' into dk/powered-by

eadc94c

davekiss added 5 commits October 1, 2024 13:43

Merge branch 'main' into dk/powered-by

b1e950c

Add a test for rendering

247a97b

Merge branch 'main' into dk/powered-by

7e5dd56

Merge branch 'main' into dk/powered-by

9eb60ed

Merge branch 'main' into dk/powered-by

ee83fc1

vercel bot deployed to Preview – elements-demo-vanilla January 7, 2025 15:24 View deployment

davekiss added 2 commits January 7, 2025 15:57

feat: add proudlyDisplayMuxBadge prop for React

3ad071a

chore: document use and example

36aa9c6

vercel bot deployed to Preview – elements-demo-astro January 7, 2025 22:40 View deployment

vercel bot temporarily deployed to Preview – elements-demo-create-react-app January 7, 2025 22:40 Inactive

vercel bot deployed to Preview – elements-demo-svelte-kit January 7, 2025 22:42 View deployment

vercel bot deployed to Preview – elements-demo-vanilla January 7, 2025 22:42 View deployment

vercel bot deployed to Preview – elements-demo-nextjs January 7, 2025 22:42 View deployment

cjpillsbury reviewed Jan 7, 2025

View reviewed changes

packages/mux-player/REFERENCE.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview – elements-demo-vue January 7, 2025 22:44 View deployment

cjpillsbury reviewed Jan 7, 2025

View reviewed changes

examples/nextjs-with-typescript/pages/MuxPlayer.tsx Show resolved Hide resolved

cjpillsbury requested changes Jan 7, 2025

View reviewed changes

davekiss added 2 commits January 8, 2025 07:07

Add bool toggle

9fa4ffe

Add attribute

99b369b

davekiss requested a review from cjpillsbury January 8, 2025 12:22

vercel bot deployed to Preview – elements-demo-nextjs January 8, 2025 17:12 View deployment

davekiss added 3 commits January 8, 2025 13:10

Remove stray pipe

bae8f59

Fix markdown

e03ac2d

Undo accidental change

7097905

luwes reviewed Jan 10, 2025

View reviewed changes

packages/mux-player/src/index.ts Show resolved Hide resolved

luwes reviewed Jan 10, 2025

View reviewed changes

packages/mux-player/src/themes/gerwig/gerwig.html Outdated Show resolved Hide resolved

luwes reviewed Jan 10, 2025

View reviewed changes

packages/mux-player/src/index.ts Outdated Show resolved Hide resolved

davekiss and others added 4 commits January 13, 2025 12:04

Remove case

5cf3f9b

Co-authored-by: Wesley Luyten <me@wesleyluyten.com>

Merge branch 'main' into dk/powered-by

052055d

Add to ThemeAttributeNames

f486f1d

Remove from media controller

e5814c7

vercel bot deployed to Preview – elements-demo-nextjs January 13, 2025 18:08 View deployment

luwes approved these changes Jan 13, 2025

View reviewed changes

Prefer aTimeout

3b10d26

davekiss merged commit 2343df8 into muxinc:main Jan 13, 2025
3 checks passed

github-actions bot mentioned this pull request Jan 13, 2025

chore: release main #1057

Merged

github-actions bot mentioned this pull request Sep 9, 2025

chore: release main #1196

Closed

Conversation

davekiss commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Sep 19, 2024

Uh oh!

dylanjha commented Sep 19, 2024

Uh oh!

vercel bot commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 21, 2024

Codecov Report

Uh oh!

Uh oh!

Uh oh!

cjpillsbury commented Jan 7, 2025

Uh oh!

cjpillsbury left a comment

Choose a reason for hiding this comment

Uh oh!

davekiss commented Jan 8, 2025

Uh oh!

cjpillsbury commented Jan 8, 2025

Uh oh!

notion-workspace bot commented Jan 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luwes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

davekiss commented Sep 19, 2024 •

edited

Loading

vercel bot commented Sep 19, 2024 •

edited

Loading