Skip to content

fix: Patch Memory Leaks #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spuppo-mux merged 12 commits into from
Feb 19, 2026
Merged

fix: Patch Memory Leaks #1261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a302756
Added some functions to cleanup hanging memory
spuppo-mux Jan 9, 2026
2c631ea
Updated next version to fix broken example
spuppo-mux Jan 9, 2026
f26b297
Disable hotkeys on disconnect
spuppo-mux Jan 14, 2026
63ee59e
Cleanup media container on disconnect
spuppo-mux Jan 14, 2026
167162a
Fixed aria-hidden warning
spuppo-mux Jan 14, 2026
ed8b25f
Media chrome button event setup
spuppo-mux Jan 14, 2026
6c50efd
General event listener setups and teardowns on connect/disconnect
spuppo-mux Jan 14, 2026
5818e09
Last round of cleanups
spuppo-mux Jan 16, 2026
91bf5b6
Found these two when testing media elements
spuppo-mux Feb 9, 2026
75f3a92
Fixes from PR review, removed unnecessary eventsetup check
spuppo-mux Feb 9, 2026
c0e4779
Reworked accessibility handling
spuppo-mux Feb 10, 2026
53a990f
Removed ariaHidden from video element and fixed comment
spuppo-mux Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/nextjs-with-typescript/next-env.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference types="next/navigation-types/compat/navigation" />
import "./.next/dev/types/routes.d.ts";

// NOTE: This file should not be edited
// see https://nextjs.org/docs/app/api-reference/config/typescript for more information.
126 changes: 55 additions & 71 deletions examples/nextjs-with-typescript/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/nextjs-with-typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@mui/material": "^7.0.2",
"@mux/mux-video": "^0.17.5",
"media-chrome": "file:../../",
"next": "15.3.8",
"next": "~16.1.1",
"react": "19.2.2",
"react-dom": "19.2.2"
},
Expand Down
5 changes: 3 additions & 2 deletions examples/nextjs-with-typescript/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"moduleResolution": "bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",
"jsx": "react-jsx",
"incremental": true,
"plugins": [
{
Expand All @@ -32,7 +32,8 @@
"next-env.d.ts",
"**/*.ts",
"**/*.tsx",
".next/types/**/*.ts"
".next/types/**/*.ts",
".next/dev/types/**/*.ts"
],
"exclude": [
"node_modules"
Expand Down
74 changes: 74 additions & 0 deletions examples/vanilla/memory-leak-tester.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
<!DOCTYPE html>
<html>
<head>
<meta name="viewport" content="width=device-width" />
<title>&lt;mux-video&gt; example</title>
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/water.css@2/out/water.css">
<script type="module" src="../../dist/index.js"></script>
<style>
mux-video {
display: block;
width: 100%;
aspect-ratio: 16 / 9;
margin: 1rem 0 2rem;
}
</style>
</head>
<body>
<button id="mount">Mount player</button>
<button id="unmount">Unmount player</button>

<div id="root"></div>

<script type="module">
const root = document.getElementById('root');
let controller = null;

function mount() {
if (controller) return;

controller = document.createElement('media-controller');

controller.innerHTML = `
<video
slot="media"
playsinline
src="https://stream.mux.com/A3VXy02VoUinw01pwyomEO3bHnG4P32xzV7u1j1FSzjNg/high.mp4">
</video>
<media-poster-image
slot="poster"
src="https://image.mux.com/A3VXy02VoUinw01pwyomEO3bHnG4P32xzV7u1j1FSzjNg/thumbnail.jpg"
placeholdersrc="data:image/jpeg;base64,/9j/2wBDABQODxIPDRQSEBIXFRQYHjIhHhwcHj0sLiQySUBMS0dARkVQWnNiUFVtVkVGZIhlbXd7gYKBTmCNl4x9lnN+gXz/2wBDARUXFx4aHjshITt8U0ZTfHx8fHx8fHx8fHx8fHx8fHx8fHx8fHx8fHx8fHx8fHx8fHx8fHx8fHx8fHx8fHx8fHz/wAARCAAUADADASIAAhEBAxEB/8QAGAAAAwEBAAAAAAAAAAAAAAAAAAECBAP/xAAdEAEBAAEEAwAAAAAAAAAAAAAAARECAxITFCFR/8QAGQEAAwADAAAAAAAAAAAAAAAAAAEDAgQF/8QAGBEBAQEBAQAAAAAAAAAAAAAAAAETERL/2gAMAwEAAhEDEQA/ANeC4ldyI1b2EtIzzrrIqYZLvl5FGkGdbfQzGPvo76WsPxXLlfqbaA5va2iVJADgPELACsD/2Q==">
</media-poster-image>

<media-loading-indicator
slot="centered-chrome"
noautohide>
</media-loading-indicator>

<media-control-bar>
<media-play-button></media-play-button>
<media-mute-button></media-mute-button>
<media-volume-range></media-volume-range>
<media-time-display></media-time-display>
<media-time-range></media-time-range>
<media-duration-display></media-duration-display>
<media-playback-rate-button></media-playback-rate-button>
<media-fullscreen-button></media-fullscreen-button>
</media-control-bar>
`;
root.appendChild(controller);
}

function unmount() {
if (!controller) return;

controller.remove();
controller = null;
}

document.getElementById('mount').addEventListener('click', mount);
document.getElementById('unmount').addEventListener('click', unmount);
</script>
</body>
</html>
Loading