Skip to content

fix: thumbnail preview sizing#1262

Merged
Jerricho93 merged 6 commits intomuxinc:mainfrom
Jerricho93:fix/thumbnail-preview-sizing
Feb 19, 2026
Merged

fix: thumbnail preview sizing#1262
Jerricho93 merged 6 commits intomuxinc:mainfrom
Jerricho93:fix/thumbnail-preview-sizing

Conversation

@Jerricho93
Copy link
Contributor

Closes #1160

Added property of "object-fit: fill" to the thumbnail preview component to allow for more dimensions, such as square thumbnail previews, or if the user wants the height to be greater than width. This will however most likely result in a stretched preview of the video to match the new aspect ratio

@Jerricho93 Jerricho93 requested review from a team and heff as code owners February 10, 2026 16:50
@vercel
Copy link

vercel bot commented Feb 10, 2026

@Jerricho93 is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@snyk-io
Copy link

snyk-io bot commented Feb 10, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
media-chrome Ready Ready Preview, Comment Feb 19, 2026 6:53pm
media-chrome-demo-nextjs Ready Ready Preview, Comment Feb 19, 2026 6:53pm
media-chrome-docs Ready Ready Preview, Comment Feb 19, 2026 6:53pm

Request Review

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 6.06061% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.61%. Comparing base (3ea80df) to head (9f46cda).
⚠️ Report is 278 commits behind head on main.

Files with missing lines Patch % Lines
src/js/media-preview-thumbnail.ts 3.12% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
- Coverage   78.55%   73.61%   -4.95%     
==========================================
  Files          59       56       -3     
  Lines       11080    13844    +2764     
  Branches        0      784     +784     
==========================================
+ Hits         8704    10191    +1487     
- Misses       2376     3619    +1243     
- Partials        0       34      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing the size of the media preview thubmnail is not working

2 participants