Open
Conversation
|
@Jerricho93 is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1266 +/- ##
==========================================
- Coverage 78.55% 73.61% -4.95%
==========================================
Files 59 56 -3
Lines 11080 13844 +2764
Branches 0 784 +784
==========================================
+ Hits 8704 10191 +1487
- Misses 2376 3619 +1243
- Partials 0 34 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1260
Changes the getter function for hotkeys to detect as attribute list instead of plain string.
Also fixes minor typo in docs
Note
Medium Risk
Changes the public
MediaController.hotkeysgetter from a string to anAttributeTokenList, which may break consumers that read it as a plain attribute value even though it matches documented/expected usage.Overview
Fixes
MediaController.hotkeysto return the internalAttributeTokenList(rather than the rawhotkeysattribute string), enabling programmaticadd/removeusage to correctly reflect and update allowed keyboard shortcuts.Also fixes a typo in the keyboard shortcuts docs example (
mc.hotkeys.add(...)) by correcting the missing quote.Written by Cursor Bugbot for commit eb8ce97. This will update automatically on new commits. Configure here.