Skip to content

fix: hotkeys properties support#1266

Open
Jerricho93 wants to merge 1 commit intomuxinc:mainfrom
Jerricho93:fix/hotkeys-properties
Open

fix: hotkeys properties support#1266
Jerricho93 wants to merge 1 commit intomuxinc:mainfrom
Jerricho93:fix/hotkeys-properties

Conversation

@Jerricho93
Copy link
Contributor

@Jerricho93 Jerricho93 commented Mar 5, 2026

Fixes #1260

Changes the getter function for hotkeys to detect as attribute list instead of plain string.

Also fixes minor typo in docs


Note

Medium Risk
Changes the public MediaController.hotkeys getter from a string to an AttributeTokenList, which may break consumers that read it as a plain attribute value even though it matches documented/expected usage.

Overview
Fixes MediaController.hotkeys to return the internal AttributeTokenList (rather than the raw hotkeys attribute string), enabling programmatic add/remove usage to correctly reflect and update allowed keyboard shortcuts.

Also fixes a typo in the keyboard shortcuts docs example (mc.hotkeys.add(...)) by correcting the missing quote.

Written by Cursor Bugbot for commit eb8ce97. This will update automatically on new commits. Configure here.

@Jerricho93 Jerricho93 requested review from a team and heff as code owners March 5, 2026 19:55
@vercel
Copy link

vercel bot commented Mar 5, 2026

@Jerricho93 is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@snyk-io
Copy link

snyk-io bot commented Mar 5, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.61%. Comparing base (3ea80df) to head (eb8ce97).
⚠️ Report is 281 commits behind head on main.

Files with missing lines Patch % Lines
src/js/media-controller.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1266      +/-   ##
==========================================
- Coverage   78.55%   73.61%   -4.95%     
==========================================
  Files          59       56       -3     
  Lines       11080    13844    +2764     
  Branches        0      784     +784     
==========================================
+ Hits         8704    10191    +1487     
- Misses       2376     3619    +1243     
- Partials        0       34      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spuppo-mux spuppo-mux self-assigned this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'hotkeys' property not available on media-controller

2 participants