Make pdepend/pdepend a dev dependency #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbos
approved these changes
Dec 4, 2025
Owner
mvdbos
left a comment
mvdbos
left a comment
There was a problem hiding this comment.
Indeed not used right now. Good catch. Merging this now. I may add it back to the tests later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for not identifying this earlier (
composer updatedoes not list every incompatibility at once but rather displays another one after the 1st one is fixed).We have the same issue as with phan/phan: pdepend/pdepend is not yet compatible with Symfony 8, but it does not seem to be used by php-spider.
I move it to dev dependencies, but you may want to remove it completely? Or call
vendor/bin/pdependin the tests and do something with the output?Best regards