Fix #10: PK for local secondary index must default to 'pk'#22
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #10 by ensuring that Local Secondary Indexes (LSI) in DynamoDB share the same partition key field name (pk) as the primary index, which is a requirement for LSI in DynamoDB.
Key Changes:
- Added
isLocalSecondaryIndexhelper function to identify LSI indexes (lsi1-lsi5) - Modified field name generation logic to omit the index prefix for LSI partition keys
- Added a demo example showing LSI usage with the
byAgeindex
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/decorators/$index.ts | Implements LSI partition key field name logic to ensure LSI indexes share the same pk field as the primary index |
| demo/main.tsp | Adds example usage of Local Secondary Index (lsi1) for querying Person by age |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.