Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TypeSpec-to-ElectroDB emitter to correctly handle enum arrays by converting them to DynamoDB/ElectroDB "set" types instead of "list" types. This change ensures that enum arrays use the more appropriate set type for storing multiple enum values, which aligns better with DynamoDB's native set data type for storing collections of unique values.
Key changes:
- Modified
emitArrayModelfunction to detect enum arrays and emit them as "set" type with enum values as items - Added two new enum definitions (
PersonStatusandCoffeePreferences) to the test model - Added comprehensive test coverage for the enum array to set conversion
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/main.tsp | Added two new enum types and corresponding fields to the Person model: status (single enum) and coffeePreferences (enum array) to demonstrate and test the new functionality |
| test/entities.test.js | Added comprehensive test suite for the coffeePreferences enum array field, verifying it's correctly emitted as a set type with the appropriate enum values |
| src/emitter.ts | Enhanced emitArrayModel function to detect enum element types and emit them as "set" type instead of "list" type, extracting enum values as the set items |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21