Open
Conversation
If first condition is true the next one can not be. Simplify condition validation. On the other hand, this has performance improvement. Signed-off-by: Andrej Valek <andy@skyrain.eu>
andy9a9
force-pushed
the
feat/improvements
branch
2 times, most recently
from
8777bc8 to
af9d663
Compare
Kicad v8 has this attribute defined to "8.0". So once reading/writing this kind of file the value shouldn't disappear. Keep it backport compatible with older version, where this attribute does not exist. Signed-off-by: Andrej Valek <andy@skyrain.eu>
andy9a9
force-pushed
the
feat/improvements
branch
from
af9d663 to
487a0e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ifwithelifwhere possibleifcondition. This has a bunch of improvements on performance.generator_versionattribute intosymbolandfootprint"8.0". So once reading/writing this kind of file the value shouldn't disappear.