Skip to content

fix(distributions): Added check if estimate_kws["bins"] is a str. #3874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hannes237 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −4
Open

fix(distributions): Added check if estimate_kws["bins"] is a str. #3874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions seaborn/distributions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,10 +400,12 @@ def plot_univariate_histogram(
_check_argument("element", ["bars", "step", "poly"], element)

auto_bins_with_weights = (
"weights" in self.variables
and estimate_kws["bins"] == "auto"
and estimate_kws["binwidth"] is None
and not estimate_kws["discrete"]
isinstance(estimate_kws["bins"], str) and (
"weights" in self.variables
and estimate_kws["bins"] == "auto"
and estimate_kws["binwidth"] is None
and not estimate_kws["discrete"]
)
)
if auto_bins_with_weights:
msg = (
Expand Down