feat: cache InnerNodeInner seq to index to make locate faster#20
Closed
EastSun5566 wants to merge 1 commit intomweidner037:masterfrom
Closed
feat: cache InnerNodeInner seq to index to make locate faster#20EastSun5566 wants to merge 1 commit intomweidner037:masterfrom
InnerNodeInner seq to index to make locate faster#20EastSun5566 wants to merge 1 commit intomweidner037:masterfrom
Conversation
Owner
|
While this may speed up read-heavy workloads, I don't think it is worth the increased memory usage. Memory usage is the more important constraint in practice when working with large documents. |
Contributor
Author
|
Got it! That makes sense. I’ll close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I implemented #18 , I found that
locateis heavily used. I added a small cache toInnerNodeInnerso finding the index by sequence can be done in O(1). All existing tests have passed.