Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean-up and bug fixes following changes to AbstractDiffractometer.
There are also some config and GPhL changes.
NB The diffractometer attributes use_sample_changer and set_grid_direction, used in tree_brick and (mxcubecore) QtGraphicsManager have disappeared, and it was not clear (to me) how to replace their use. The lines using them have been simply commented out - search the code for 'BROKEN'. Someone using mxcubeqt on a live beamline needs to look at this.
Mock version runs - with these fixes.