AbstractDiffractometer and AbstartSampleView #2000
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🎉 🥳 |
Use reject_centring instead of cancel_centring when abort the centring. Change phi to omega in the GridForm
Change logic in _centring_started. Add missing float type for sample changer input model.
# Conflicts: # pyproject.toml # ui/src/components/Tasks/DataCollection.jsx
marcus-oscarsson
added a commit
that referenced
this pull request
Feb 4, 2026
marcus-oscarsson
added a commit
that referenced
this pull request
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #1881.
Changes due to AbstractDiffractometer and AbstartSampleView new implementation. Dependant on mxcube/mxcubecore/pull/1479