Pre-fill unit cell params for DC in samples tab#2030
Merged
marcus-oscarsson merged 1 commit intomxcube:developfrom Feb 18, 2026
Merged
Pre-fill unit cell params for DC in samples tab#2030marcus-oscarsson merged 1 commit intomxcube:developfrom
marcus-oscarsson merged 1 commit intomxcube:developfrom
Conversation
github.com/mxcube/pull/1998 has introduced a way of filling unit cell parameters using LIMS data. Current approach has two flaws: 1. It works only when invoking DC from sample view's context menu due to the way information about selected state is stored in the redux state. 2. It does not fill the crystal space group properly. The UI control is named 'space_group', rather than 'crystalSpaceGroup'.
marcus-oscarsson
force-pushed
the
pm-pre-fill-from-samples-tab
branch
from
d60bbf1 to
879a1de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.com//pull/1998 has introduced a way of filling unit cell parameters using LIMS data.
Current approach has two flaws: