Fix cell counting related SampleView filling#2036
Merged
marcus-oscarsson merged 2 commits intomxcube:developfrom Mar 4, 2026
Merged
Fix cell counting related SampleView filling#2036marcus-oscarsson merged 2 commits intomxcube:developfrom
marcus-oscarsson merged 2 commits intomxcube:developfrom
Conversation
marcus-oscarsson
force-pushed
the
fix-cell-counting
branch
from
006d5f9 to
b6a7288
Compare
Member
|
Thanks @matyson, well done ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to update the heatmap results after a mesh scan we noticed that the cell filling was not considering the cell counting method (e.g. zig-zag, inverse-zig-zag) to fill the grid's result. This was due to the
SampleImagecomponent not being initialized correctly from config params fromstate.taskForm.defaultParameters.mesh.cell_counting->state.taskForm.defaultParameters.mesh.acq_parameters.cell_counting.Then, we included the countCellFun call inside the cell filling function to populate the correct matrix position according to the cellCount order.