Draft: validate prefix instead of filename and stricter regexp#2038
Closed
epanepucci wants to merge 1 commit intomxcube:developfrom
Closed
Draft: validate prefix instead of filename and stricter regexp#2038epanepucci wants to merge 1 commit intomxcube:developfrom
epanepucci wants to merge 1 commit intomxcube:developfrom
Conversation
- the current validation regexp allows characters that are not UNIX friendly because it validates against the filename prop that is used to indicate the *template* of the filenames that will be generated - this simplified regexp validates only against valid UNIX characters except the 'dot' character - it also validates the prefix prop which is editable by the user
Member
|
It seems like a reasonable fix, why did you close it ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataCollection.jsx +370
this simplified regexp validates only against valid UNIX characters except the 'dot' character
it also validates the prefix prop which is editable by the user instead of the filename