Skip to content

Conversation

@simei2k
Copy link

@simei2k simei2k commented Apr 3, 2025

Description

This PR addresses a critical security vulnerability in SSL certificate validation by implementing proper certificate chain verification. The fix replaces an insecure "trust-all" TrustManager with a secure implementation that maintains full certificate validation while adding time leeway for certificate expiration.

Fix was done by:

  • Implementing proper TrustManager delegation to system validators
  • Adding a TimeLeewayCertificate wrapper that only modifies date validation
  • Adding a strict SSLContext option for higher security requirements

This fix was originally done in the repo provided below but not applied here.

References
Related fix commit .

@994108345
Copy link

994108345 commented Apr 3, 2025 via email

@BlueLeer
Copy link

BlueLeer commented Apr 3, 2025 via email

@liumw-git
Copy link

liumw-git commented Apr 3, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants