Skip to content

Agent tests #23

Merged
satwikkansal merged 5 commits intomasterfrom
agent-tests-only
May 24, 2025
Merged

Agent tests #23
satwikkansal merged 5 commits intomasterfrom
agent-tests-only

Conversation

@satwikkansal
Copy link
Collaborator

No description provided.

@satwikkansal satwikkansal requested review from Copilot and gautamp8 and removed request for Copilot and gautamp8 May 23, 2025 10:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes docstring formatting across tools and scripts, refines type hints and exception handling in the email processing task, and updates module imports and the CI workflow.

  • Added consistent blank lines before closing docstrings.
  • Refactored process_email_task to return a structured DetailedEmailProcessingResult and improved unsupported-handle error handling.
  • Fixed import ordering in __init__.py, updated type hints to PEP 585 generics, and enhanced environment‐variable safety in the API and CI.

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.

Show a summary per file
File Description
mxtoai/tools/schedule_tool.py Adjusted docstring formatting.
mxtoai/tools/mock_jina_service.py Adjusted docstring formatting.
mxtoai/tools/fallback_search_tool.py Adjusted docstring formatting.
mxtoai/tools/attachment_processing_tool.py Adjusted docstring formatting.
mxtoai/tools/init.py Re-enabled import of SearchWithFallbackTool and updated __all__.
mxtoai/tasks.py Refactored process_email_task return type and error branches using DetailedEmailProcessingResult.
mxtoai/routed_litellm_model.py Switched to built-in generics (dict[str, Any], list[...]) and unified exception instantiation.
mxtoai/prompts/base_prompts.py Removed an extra blank line for docstring consistency.
mxtoai/models.py Updated typing hints to use PEP 585 list[...] and dict[...].
mxtoai/instruction_resolver.py Consolidated exception message assignment before raising UnspportedHandleException.
mxtoai/exceptions.py Added spacing around class definitions (no functional changes).
mxtoai/email_sender.py Added blank lines in docstrings for send_email, send_reply, and related methods.
mxtoai/api.py Switched to os.getenv for IS_PROD, cleaned up whitespace.
mxtoai/scripts/* Standardized docstring formatting across all script tools.
.github/workflows/tests.yml Added AZURE_OPENAI_API_KEY secret injection and a TODO note in the CI workflow.
Comments suppressed due to low confidence (3)

mxtoai/tasks.py:90

  • This Dramatiq actor now returns a complex Pydantic model. Ensure you have a results backend configured or consider returning a primitive/dict for compatibility with task result serialization.
def process_email_task(

mxtoai/tools/init.py:5

  • The import path search_with_fallback_tool does not match the actual file name fallback_search_tool.py. Update the module name or file to ensure the import resolves correctly.
from mxtoai.tools.search_with_fallback_tool import SearchWithFallbackTool

.github/workflows/tests.yml:26

  • [nitpick] Leaving TODO comments in the CI workflow can cause confusion. Consider removing or addressing this note before merging.
      # TODO: Ideally, this shouldn't be needed, remove later

@satwikkansal satwikkansal merged commit 518a9f7 into master May 24, 2025
1 of 2 checks passed
@BhaveshKukreja29 BhaveshKukreja29 deleted the agent-tests-only branch January 12, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants