feat: update bedrock resource attributes #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyuan-he
commented
Oct 9, 2024
...-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/RequestAccess.java
Show resolved
Hide resolved
zzhlogin
reviewed
Oct 9, 2024
...y/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AwsExperimentalAttributes.java
Show resolved
Hide resolved
zzhlogin
reviewed
Oct 9, 2024
...ava/io/opentelemetry/instrumentation/awssdk/v1_11/AwsSdkExperimentalAttributesExtractor.java
Show resolved
Hide resolved
zzhlogin
reviewed
Oct 9, 2024
...-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/RequestAccess.java
Show resolved
Hide resolved
zzhlogin
reviewed
Oct 9, 2024
....2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsSdkRequestType.java
Show resolved
Hide resolved
zzhlogin
approved these changes
Oct 10, 2024
mxiamxia
approved these changes
Oct 11, 2024
mxiamxia
added a commit
to aws-observability/aws-otel-java-instrumentation
that referenced
this pull request
Oct 12, 2024
### *Summary of Changes:* - Updating the CFN Primary Id for Guardrail to be the ARN. (Verified this in the AWS Cloudformation Console)  - Updated `BEDROCKAGENTOPERATION` enum. - Our Bedrock Agent Runtime should support both Agent Operation and KnowledgeBased Operation [like in Java SDK v1](https://github.com/mxiamxia/opentelemetry-java-instrumentation/blob/965f7878c79c2be5851f23cf272edd39585f42af/instrumentation/aws-sdk/aws-sdk-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/AwsSdkExperimentalAttributesExtractor.java#L133). Related changes in upstream package: mxiamxia/opentelemetry-java-instrumentation#13 ### *Testing Plan:* Set up sample apps and manually verified correct span attributes were generated via auto-instrumentation. `Java SDK v1`  `Java SDK v2`  By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: Min Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
Updating the CFN Primary Id for Guardrail to be the ARN. (Verified this in the AWS Cloudformation Console)
Updated
BEDROCKAGENTOPERATIONenum.Related changes in ADOT package: aws-observability/aws-otel-java-instrumentation#905
Testing Plan:
Set up sample apps and manually verified correct span attributes were generated via auto-instrumentation.
Java SDK v1Java SDK v2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.