Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 10, 2025

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps golang.org/x/sync from 0.10.0 to 0.16.0.

Commits
  • 7fad2c9 errgroup: revert propagation of panics
  • 8a14946 errgroup: remove duplicated comment
  • 1869c69 all: replace deprecated ioutil
  • d1ac909 sync/errgroup: PanicError.Error print stack trace
  • 506c70f errgroup: propagate panic and Goexit through Wait
  • 396f3a0 errgroup: document calling Go before Wait
  • b637f27 errgroup: drop support for Go versions before 1.20
  • 960bf1f all: upgrade go directive to at least 1.23.0 [generated]
  • fe3591b sync/errgroup: improve documentation for semaphore limit behavior
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 10, 2025
@mxpv
Copy link
Owner

mxpv commented Jul 14, 2025

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/golang.org/x/sync-0.16.0 branch from 91e3a25 to c7785c3 Compare July 14, 2025 18:54
@mxpv
Copy link
Owner

mxpv commented Jul 14, 2025

@claude can you fix build errors?

@claude
Copy link
Contributor

claude bot commented Jul 14, 2025

Claude finished @mxpv's task —— View job


✅ Build errors from golang.org/x/sync upgrade - PARTIALLY FIXED

I've analyzed and fixed the build errors caused by the golang.org/x/sync upgrade from 0.10.0 to 0.16.0.

Todo List:

  • Check current build status and identify specific errors
  • Search codebase for golang.org/x/sync usage
  • Analyze breaking changes in the upgrade
  • Implement compatibility fixes
  • Run tests to verify fixes work
  • Commit changes (blocked by permissions)

Root Cause Analysis:

The golang.org/x/sync v0.16.0 upgrade requires Go 1.23+, but the CI workflow was configured for Go 1.18. This caused the error:

invalid go version '1.23.0': must match format 1.23

✅ What I Fixed:

  1. go.mod compatibility: Updated to properly support Go 1.23.0 requirement
  2. Local verification: Confirmed make build and make test both pass

⚠️ Manual Action Required:

I cannot push changes to workflow files due to GitHub App permissions. To complete the fix:

Update .github/workflows/ci.yml (lines 23 and 39):

- go-version: 1.18
+ go-version: 1.24

Why This Change is Safe:

  • Go 1.24 is backward compatible with existing code
  • All tests pass locally with the new version
  • golang.org/x/sync v0.16.0 includes important panic handling fixes for errgroup

Once the workflow is updated, the CI should pass successfully.


@mxpv mxpv force-pushed the dependabot/go_modules/golang.org/x/sync-0.16.0 branch from b36d582 to c7785c3 Compare July 14, 2025 19:20
@mxpv
Copy link
Owner

mxpv commented Jul 14, 2025

https://github.com/dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/golang.org/x/sync-0.16.0 branch from c7785c3 to 27a26ff Compare July 14, 2025 19:34
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.10.0 to 0.16.0.
- [Commits](golang/sync@v0.10.0...v0.16.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-version: 0.16.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/golang.org/x/sync-0.16.0 branch from 27a26ff to a4e06c9 Compare July 14, 2025 19:41
@mxpv mxpv merged commit d2587f3 into main Jul 14, 2025
5 checks passed
@mxpv mxpv deleted the dependabot/go_modules/golang.org/x/sync-0.16.0 branch July 14, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants