[ISSUE #2604] Remove AdminBrokerProcessor unused code

[Brijeshthummar02]

Which Issue(s) This PR Fixes(Closes)

Fixes #2604

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

• Refactor
  • Streamlined the initialization process for the administrative broker component by removing extraneous parameters, resulting in a cleaner and more maintainable configuration setup without impacting current functionality.

[coderabbitai]

Walkthrough

This pull request simplifies the new method of the AdminBrokerProcessor by removing a block of commented-out parameters. The method now accepts only the broker_runtime_inner parameter, eliminating unused configurations and streamlining the constructor without affecting the existing logic.

Changes

File	Change Summary
rocketmq-broker/src/processor/admin_broker_processor.rs	Removed commented-out parameters from the new method signature in AdminBrokerProcessor, retaining only the broker_runtime_inner parameter for initialization.

Possibly related PRs

• [ISSUE #2298]⚡️Remove PopMessageProcessor useless code #2299 – Simplified a similar constructor by retaining only broker_runtime_inner and removing unnecessary parameters.
• [ISSUE #2526] Remove ConsumerManageProcessor unused code #2529 – Addressed cleanup by removing commented-out code in the constructor of AdminBrokerProcessor and related components.
• [Enhancement⚡️] Remove SendMessageProcessor useless code #2584 #2585 – Related changes in the SendMessageProcessor's new method, focusing on the removal of parameters to streamline constructors.

Suggested labels

approved

Suggested reviewers

• TeslaRustor
• SpaceXCN
• rocketmq-rust-bot

Poem

I'm just a little rabbit, hopping through the code,
Clearing out the clutter on this streamlined road.
Comments have vanished, and parameters are few,
A cleaner, leaner constructor now shining through.
With every hop, I cheer for changes bold and new!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a182230 and 3fe4c12.

📒 Files selected for processing (1)

• rocketmq-broker/src/processor/admin_broker_processor.rs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• rocketmq-broker/src/processor/admin_broker_processor.rs

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: build (windows-latest, nightly)
• GitHub Check: build (windows-latest, stable)
• GitHub Check: build (macos-latest, nightly)
• GitHub Check: build (macos-latest, stable)
• GitHub Check: build (ubuntu-latest, nightly)
• GitHub Check: test
• GitHub Check: build (ubuntu-latest, stable)
• GitHub Check: build
• GitHub Check: auto-approve

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[rocketmq-rust-bot]

🔊@Brijeshthummar02 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.61%. Comparing base (2d67e35) to head (3fe4c12).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...tmq-broker/src/processor/admin_broker_processor.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2605   +/-   ##
=======================================
  Coverage   28.60%   28.61%           
=======================================
  Files         515      515           
  Lines       74570    74553   -17     
=======================================
  Hits        21334    21334           
+ Misses      53236    53219   -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mxsm]

@Brijeshthummar02 Thanks for your contribution. Please use cargo fmt to fix code style and fix ci error

[rocketmq-rust-bot]

🔊@Brijeshthummar02 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

[rocketmq-rust-bot]

LGTM

[mxsm]

LGTM