Skip to content

[ISSUE #2622]💫Change MessageStoreConfig timer_wheel_enable default value from true to false🔥 #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rocketmq-rust-bot merged 1 commit into from
Feb 28, 2025
Merged

[ISSUE #2622]💫Change MessageStoreConfig timer_wheel_enable default value from true to false🔥 #2623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rocketmq-store/src/config/message_store_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ impl Default for MessageStoreConfig {
timer_enable_check_metrics: false,
timer_intercept_delay_level: false,
timer_max_delay_sec: 0,
timer_wheel_enable: false,
timer_wheel_enable: true,
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Inconsistency between PR objective and code implementation

The PR objective states the goal is to change timer_wheel_enable default value from true to false, but the actual implementation changes it from false to true. This is the opposite of what was intended according to the PR description.

-            timer_wheel_enable: true,
+            timer_wheel_enable: false,
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
timer_wheel_enable: true,
timer_wheel_enable: false,

disappear_time_after_start: -1,
timer_stop_enqueue: false,
timer_check_metrics_when: "".to_string(),
Expand Down
Loading