[ISSUE #2610] Remove ReplyMessageProcessor useless code

[siddheshzz]

Which Issue(s) This PR Fixes(Closes)

Fixes #2610

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

• Refactor
  • Streamlined the initialization of a core messaging component by removing unnecessary dependencies and cleaning up its configuration.
  • Simplified the component’s setup to improve code clarity without altering its outward behavior.

[rocketmq-rust-bot]

🔊@siddheshzz 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

[coderabbitai]

Walkthrough

The PR refactors the instantiation of the ReplyMessageProcessor in both the BrokerRuntime and the processor module. Several dependencies and parameters previously passed during construction—such as topic, subscription, and producer management components and the store_host—have been removed. The change simplifies the constructor calls without altering public interfaces or core functionality, reducing coupling between components.

Changes

File	Changes Summary
rocketmq-broker/src/broker_runtime.rs	Removed multiple cloned dependencies from ReplyMessageProcessor initialization, keeping only transactional_message_service and inner.
rocketmq-broker/src/.../reply_message_processor.rs	Removed the store_host field and eliminated parameters for rebalance_lock_manager, broker_stats_manager, and producer_manager from the new constructor.

Possibly related PRs

• [Enhancement⚡️] Remove SendMessageProcessor useless code #2584 #2585: Involves similar modifications to ReplyMessageProcessor and BrokerRuntime by simplifying dependency injection.
• [ISSUE #2331]🤡Remove PopBufferMergeService useless code🧑‍💻 #2332: Focuses on removing the store_host field and related parameters, directly aligning with the changes in the main PR.
• [ISSUE #2526] Remove ConsumerManageProcessor unused code #2529: Simplifies constructor parameters in a different processor, reflecting a consistent approach to reducing unnecessary dependencies.

Suggested labels

enhancement⚡️, approved, auto merge, AI review first, rocketmq-broker crate

Suggested reviewers

• TeslaRustor
• SpaceXCN
• rocketmq-rust-bot
• mxsm

Poem

I'm a rabbit hopping through the code,
Skipping old parameters on a lighter road,
Simplified lines and cleaner flow,
Bouncing on refactored paths as I go,
With carrots and code, my heart does glow!
🐰💕

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d6d3a9 and db1f51e.

📒 Files selected for processing (2)

• rocketmq-broker/src/broker_runtime.rs (0 hunks)
• rocketmq-broker/src/processor/reply_message_processor.rs (0 hunks)

💤 Files with no reviewable changes (2)

• rocketmq-broker/src/broker_runtime.rs
• rocketmq-broker/src/processor/reply_message_processor.rs

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: build (windows-latest, nightly)
• GitHub Check: build (windows-latest, stable)
• GitHub Check: build (macos-latest, nightly)
• GitHub Check: build (macos-latest, stable)
• GitHub Check: build (ubuntu-latest, nightly)
• GitHub Check: build
• GitHub Check: auto-approve
• GitHub Check: build (ubuntu-latest, stable)
• GitHub Check: test

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.64%. Comparing base (5d6d3a9) to head (db1f51e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2625   +/-   ##
=======================================
  Coverage   28.63%   28.64%           
=======================================
  Files         515      515           
  Lines       74582    74557   -25     
=======================================
  Hits        21360    21360           
+ Misses      53222    53197   -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rocketmq-rust-bot]

LGTM

[mxsm]

LGTM