Skip to content

[ISSUE #2626]🐛Fix PopMessageProcessor#process error acording to Java code🔥 #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rocketmq-rust-bot merged 1 commit into from
Mar 1, 2025
Merged

[ISSUE #2626]🐛Fix PopMessageProcessor#process error acording to Java code🔥 #2627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions rocketmq-broker/src/processor/pop_message_processor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,20 +598,21 @@
)
.await
} else {
self.pop_msg_from_topic(
&topic_config,
self.pop_msg_from_queue(
&topic_config.topic_name.unwrap_or_default(),
Copy link

Copilot AI Mar 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider handling the absence of a topic name explicitly instead of defaulting to an empty string to prevent potential misrouting issues.

Copilot uses AI. Check for mistakes.
&request_header.attempt_id.clone().unwrap_or_default(),

Check warning on line 603 in rocketmq-broker/src/processor/pop_message_processor.rs

View check run for this annotation

Codecov / codecov/patch

rocketmq-broker/src/processor/pop_message_processor.rs#L601-L603 

Added lines #L601 - L603 were not covered by tests
Copy link

Copilot AI Mar 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using unwrap_or_default for attempt_id might mask configuration issues; consider adding explicit error handling if attempt_id is missing.

Copilot uses AI. Check for mistakes.
false,
get_message_result.clone(),
&request_header,
request_header.queue_id,
rest_num,
revive_qid,

Check warning on line 609 in rocketmq-broker/src/processor/pop_message_processor.rs

View check run for this annotation

Codecov / codecov/patch

rocketmq-broker/src/processor/pop_message_processor.rs#L608-L609 

Added lines #L608 - L609 were not covered by tests
channel.clone(),
pop_time,
message_filter.clone(),
&mut start_offset_info,
&mut msg_offset_info,
&mut order_count_info,
randomq,
rest_num,
)
.await
};
Expand Down
Loading