[ISSUE #3521]⚡️Increase buffer capacity for Framed connection to 1 MB in new Connection implementation

[mxsm]

Which Issue(s) This PR Fixes(Closes)

Fixes #3521

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

• Refactor
  • Increased the internal buffer size for connections to improve data handling performance.

[Copilot]

Pull Request Overview

This PR increases the buffer capacity for the Framed connection in the new Connection implementation to 1 MB as described in Issue #3521.

• Introduces a constant CAPACITY set to 1 MB.
• Updates the Framed instance initialization to use the new CAPACITY.

[rocketmq-rust-bot]

🔊@mxsm 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

[coderabbitai]

Walkthrough

The internal buffer capacity for framed connections in the Connection::new constructor was increased from 4 KB to 1 MB. This was achieved by introducing a CAPACITY constant set to 1 MB and updating its usage in the buffer initialization. No other logic or public interfaces were changed.

Changes

File(s)	Change Summary
rocketmq-remoting/src/connection.rs	Increased framed buffer capacity from 4 KB to 1 MB via a new constant

Assessment against linked issues

Objective	Addressed	Explanation
Increase buffer capacity for Framed connection to 1 MB in new Connection implementation (#3521)	✅

Poem

A buffer once tiny, now mighty and grand,
From four K to a meg, just as we planned.
Connections now flow with space to spare,
No more bottlenecks lurking there.
🐇✨
The rabbit approves, with a hop and a cheer—
Big buffers for RocketMQ, all through the year!

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

rocketmq-remoting/src/connection.rs (1)

101-103: Make buffer capacity a shared, configurable constant instead of an in-function const

Hard-coding 1 MB inside the new() constructor makes it difficult to reason about memory usage across many connections and impossible to tweak the value from a single place (or via a feature flag / config file) without touching this method.

-        const CAPACITY: usize = 1024 * 1024; // 1 MB
-        let framed = Framed::with_capacity(tcp_stream, CompositeCodec::new(), CAPACITY);
+        // Prefer a module-level or crate-level constant so it can be reused and
+        // adjusted centrally.
+        let framed =
+            Framed::with_capacity(tcp_stream, CompositeCodec::new(), BUFFER_CAPACITY_BYTES);

Suggested follow-up:

+/// Default framed buffer size per connection (1 MB).
+pub(crate) const BUFFER_CAPACITY_BYTES: usize = 1024 * 1024;

Also consider exposing a knob (e.g. via builder or config) so applications can reduce the per-connection footprint when running thousands of concurrent connections.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 39397bd and 604130d.

📒 Files selected for processing (1)

• rocketmq-remoting/src/connection.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: build (windows-latest, nightly)
• GitHub Check: build (macos-latest, stable)
• GitHub Check: test
• GitHub Check: build (windows-latest, stable)
• GitHub Check: build
• GitHub Check: build (macos-latest, nightly)
• GitHub Check: build (ubuntu-latest, nightly)
• GitHub Check: build (ubuntu-latest, stable)
• GitHub Check: auto-approve

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.20%. Comparing base (39397bd) to head (604130d).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
rocketmq-remoting/src/connection.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3522   +/-   ##
=======================================
  Coverage   26.20%   26.20%           
=======================================
  Files         555      555           
  Lines       78594    78594           
=======================================
  Hits        20593    20593           
  Misses      58001    58001           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rocketmq-rust-bot]

LGTM