Skip to content

[ISSUE #3540]⚡️Shutdown safety and state management improvements for HA services #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rocketmq-rust-bot merged 1 commit into from
Jun 26, 2025
Merged

[ISSUE #3540]⚡️Shutdown safety and state management improvements for HA services #3541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions rocketmq-store/src/ha/default_ha_connection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,10 @@
}

pub async fn shutdown(&mut self) {
{
let mut state = self.current_state.write().await;
Copy link

Copilot AI Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The shutdown implementation is duplicated in both ReadSocketService and WriteSocketService. Consider extracting the common shutdown logic into a helper method or trait to reduce code duplication and improve maintainability.

Copilot uses AI. Check for mistakes.
*state = HAConnectionState::Shutdown;

Check warning on line 403 in rocketmq-store/src/ha/default_ha_connection.rs

View check run for this annotation

Codecov / codecov/patch

rocketmq-store/src/ha/default_ha_connection.rs#L402-L403 

Added lines #L402 - L403 were not covered by tests
}
if let Some(handle) = self.service_handle.take() {
handle.abort();
let _ = handle.await;
Expand Down Expand Up @@ -626,6 +630,10 @@
}

pub async fn shutdown(&mut self) {
{
let mut state = self.current_state.write().await;
*state = HAConnectionState::Shutdown;

Check warning on line 635 in rocketmq-store/src/ha/default_ha_connection.rs

View check run for this annotation

Codecov / codecov/patch

rocketmq-store/src/ha/default_ha_connection.rs#L634-L635 

Added lines #L634 - L635 were not covered by tests
}
if let Some(handle) = self.service_handle.take() {
handle.abort();
let _ = handle.await;
Expand Down
Loading