Skip to content

[ISSUE #6231]🚀Implement Prodcer recall_message#6232

Merged
rocketmq-rust-bot merged 1 commit intomainfrom
feat-6231
Feb 8, 2026
Merged

[ISSUE #6231]🚀Implement Prodcer recall_message#6232
rocketmq-rust-bot merged 1 commit intomainfrom
feat-6231

Conversation

@mxsm
Copy link
Owner

@mxsm mxsm commented Feb 8, 2026

Which Issue(s) This PR Fixes(Closes)

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

Release Notes

  • New Features
    • Added support for message recall operations in the messaging protocol, enabling clients to request message recalls.

@rocketmq-rust-robot rocketmq-rust-robot added the feature🚀 Suggest an idea for this project. label Feb 8, 2026
@rocketmq-rust-bot
Copy link
Collaborator

🔊@mxsm 🚀Thanks for your contribution🎉!

💡CodeRabbit(AI) will review your code first🔥!

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 8, 2026

Walkthrough

This PR introduces a new RecallMessageRequestHeader struct in the rocketmq-remoting protocol module. The struct enables message recall operations with fields for producer group, topic, and recall handle. It includes serialization/deserialization support, accessor/mutator methods, and comprehensive unit tests.

Changes

Cohort / File(s) Summary
Module Declaration
rocketmq-remoting/src/protocol/header.rs
Added public module declaration to export the newly created recall_message_request_header module.
RecallMessageRequestHeader Struct
rocketmq-remoting/src/protocol/header/recall_message_request_header.rs
New struct implementing message recall request protocol header with optional producer_group, required topic and recall_handle fields. Includes constructor, accessor/mutator methods, Display trait, serialization support, and unit tests validating construction, setters, formatting, and serialization behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A header hops into the fray,
With topics, handles leading the way,
To recall what once was sent,
Through serialize's gentle bent,
Testing ensures all's well today! 📨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title references implementing 'Prodcer recall_message' but the actual changes only add the RecallMessageRequestHeader struct declaration and module export, not the full feature implementation. Clarify whether this PR completes the full recall_message feature or only adds the header struct. Consider a more precise title like 'Add RecallMessageRequestHeader struct and module' if it's partial.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The PR adds the RecallMessageRequestHeader struct with full implementation (constructor, accessors, mutators, serialization, tests), which directly fulfills the linked issue #6231 objective to add RecallMessageRequestHeader.
Out of Scope Changes check ✅ Passed All changes are within scope: the new module declaration and RecallMessageRequestHeader struct implementation directly align with the objective of issue #6231 to add RecallMessageRequestHeader.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-6231

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
rocketmq-remoting/src/protocol/header/recall_message_request_header.rs (1)

83-111: Getters and setters are unnecessary given public fields.

The fields are already pub, and per the established codebase pattern, header structs rely on direct field access rather than accessor/mutator methods. These methods add surface area without benefit and diverge from how other headers in this module are structured.

Consider removing them and accessing fields directly. The tests and any callers can just use header.topic instead of header.topic().

Based on learnings: "In the rocketmq-remoting/src/protocol/header/ module, header structs should consistently use public fields rather than private fields with getters/setters."


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.60%. Comparing base (a35ff95) to head (2965b41).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6232      +/-   ##
==========================================
+ Coverage   41.56%   41.60%   +0.04%     
==========================================
  Files         891      892       +1     
  Lines      124555   124650      +95     
==========================================
+ Hits        51772    51865      +93     
- Misses      72783    72785       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@rocketmq-rust-bot rocketmq-rust-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - All CI checks passed ✅

@rocketmq-rust-bot rocketmq-rust-bot merged commit cf46e31 into main Feb 8, 2026
19 checks passed
@rocketmq-rust-bot rocketmq-rust-bot added approved PR has approved and removed ready to review waiting-review waiting review this PR labels Feb 8, 2026
@mxsm mxsm deleted the feat-6231 branch February 22, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI review first Ai review pr first approved PR has approved auto merge feature🚀 Suggest an idea for this project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature🚀] Add RecallMessageRequestHeader

3 participants