Skip to content

[ISSUE #6539]✨TimeUtils usage to replace get_current_millis with current_millis for consistency#6540

Merged
rocketmq-rust-bot merged 1 commit intomainfrom
enh-6539
Feb 27, 2026
Merged

[ISSUE #6539]✨TimeUtils usage to replace get_current_millis with current_millis for consistency#6540
rocketmq-rust-bot merged 1 commit intomainfrom
enh-6539

Conversation

@mxsm
Copy link
Owner

@mxsm mxsm commented Feb 27, 2026

Which Issue(s) This PR Fixes(Closes)

Brief Description

How Did You Test This Change?

@rocketmq-rust-bot
Copy link
Collaborator

🔊@mxsm 🚀Thanks for your contribution🎉!

💡CodeRabbit(AI) will review your code first🔥!

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

Important

Review skipped

Too many files!

This PR contains 153 files, which is 3 over the limit of 150.

📥 Commits

Reviewing files that changed from the base of the PR and between 8277e91 and 86872c8.

📒 Files selected for processing (153)
  • rocketmq-broker/src/broker_runtime.rs
  • rocketmq-broker/src/client/client_channel_info.rs
  • rocketmq-broker/src/client/consumer_group_info.rs
  • rocketmq-broker/src/client/manager/consumer_manager.rs
  • rocketmq-broker/src/client/manager/producer_manager.rs
  • rocketmq-broker/src/client/rebalance/rebalance_lock_manager.rs
  • rocketmq-broker/src/filter/manager/consumer_filter_manager.rs
  • rocketmq-broker/src/long_polling/long_polling_service/pop_long_polling_service.rs
  • rocketmq-broker/src/long_polling/long_polling_service/pull_request_hold_service.rs
  • rocketmq-broker/src/long_polling/pop_request.rs
  • rocketmq-broker/src/offset/manager/consumer_order_info_manager.rs
  • rocketmq-broker/src/out_api/broker_outer_api.rs
  • rocketmq-broker/src/processor/ack_message_processor.rs
  • rocketmq-broker/src/processor/admin_broker_processor/subscription_group_handler.rs
  • rocketmq-broker/src/processor/change_invisible_time_processor.rs
  • rocketmq-broker/src/processor/default_pull_message_result_handler.rs
  • rocketmq-broker/src/processor/end_transaction_processor.rs
  • rocketmq-broker/src/processor/notification_processor.rs
  • rocketmq-broker/src/processor/pop_message_processor.rs
  • rocketmq-broker/src/processor/processor_service/pop_buffer_merge_service.rs
  • rocketmq-broker/src/processor/processor_service/pop_revive_service.rs
  • rocketmq-broker/src/processor/pull_message_processor.rs
  • rocketmq-broker/src/processor/recall_message_processor.rs
  • rocketmq-broker/src/processor/reply_message_processor.rs
  • rocketmq-broker/src/processor/send_message_processor.rs
  • rocketmq-broker/src/schedule/schedule_message_service.rs
  • rocketmq-broker/src/transaction/queue/default_transactional_message_service.rs
  • rocketmq-broker/src/transaction/queue/transactional_message_bridge.rs
  • rocketmq-broker/src/transaction/queue/transactional_op_batch_service.rs
  • rocketmq-broker/src/util/hook_utils.rs
  • rocketmq-client/src/base/client_config.rs
  • rocketmq-client/src/consumer/consumer_impl/consume_message_concurrently_service.rs
  • rocketmq-client/src/consumer/consumer_impl/consume_message_pop_concurrently_service.rs
  • rocketmq-client/src/consumer/consumer_impl/default_mq_push_consumer_impl.rs
  • rocketmq-client/src/consumer/consumer_impl/pop_process_queue.rs
  • rocketmq-client/src/consumer/consumer_impl/process_queue.rs
  • rocketmq-client/src/consumer/consumer_impl/pull_api_wrapper.rs
  • rocketmq-client/src/consumer/consumer_impl/re_balance/rebalance_impl.rs
  • rocketmq-client/src/consumer/consumer_impl/re_balance/rebalance_push_impl.rs
  • rocketmq-client/src/consumer/consumer_impl/re_balance/rebalance_service.rs
  • rocketmq-client/src/consumer/default_mq_push_consumer.rs
  • rocketmq-client/src/consumer/pull_callback.rs
  • rocketmq-client/src/factory/mq_client_instance.rs
  • rocketmq-client/src/implementation/client_remoting_processor.rs
  • rocketmq-client/src/latency/latency_fault_tolerance_impl.rs
  • rocketmq-client/src/producer/produce_accumulator.rs
  • rocketmq-client/src/producer/producer_impl/default_mq_producer_impl.rs
  • rocketmq-client/src/trace/trace_context.rs
  • rocketmq-common/src/common/coldctr/acc_and_time_stamp.rs
  • rocketmq-common/src/common/consumer/receipt_handle.rs
  • rocketmq-common/src/common/message/message_client_id_setter.rs
  • rocketmq-common/src/common/statistics/statistics_item.rs
  • rocketmq-common/src/common/statistics/statistics_manager.rs
  • rocketmq-common/src/common/stats/moment_stats_item.rs
  • rocketmq-common/src/common/stats/moment_stats_item_set.rs
  • rocketmq-common/src/utils/http_tiny_client.rs
  • rocketmq-common/src/utils/time_utils.rs
  • rocketmq-controller/src/heartbeat/default_broker_heartbeat_manager.rs
  • rocketmq-controller/src/task/check_not_active_broker_request.rs
  • rocketmq-namesrv/src/processor/client_request_processor.rs
  • rocketmq-namesrv/src/route/route_info_manager.rs
  • rocketmq-namesrv/src/route/route_info_manager_v2.rs
  • rocketmq-namesrv/src/route/tables/live_table.rs
  • rocketmq-remoting/src/base/request_task.rs
  • rocketmq-remoting/src/protocol.rs
  • rocketmq-remoting/src/protocol/body/consumer_running_info.rs
  • rocketmq-remoting/src/protocol/body/timer_metrics_serialize_wrapper.rs
  • rocketmq-remoting/src/protocol/header/controller/elect_master_request_header.rs
  • rocketmq-remoting/src/protocol/header/controller/register_broker_to_controller_request_header.rs
  • rocketmq-remoting/src/protocol/header/pop_message_request_header.rs
  • rocketmq-remoting/src/protocol/heartbeat/subscription_data.rs
  • rocketmq-remoting/src/protocol/static_topic/topic_queue_mapping_utils.rs
  • rocketmq-store/benches/delivery.rs
  • rocketmq-store/src/base/message_store.rs
  • rocketmq-store/src/base/store_stats_service.rs
  • rocketmq-store/src/consume_queue/mapped_file_queue.rs
  • rocketmq-store/src/ha/default_ha_client.rs
  • rocketmq-store/src/ha/default_ha_connection.rs
  • rocketmq-store/src/ha/ha_connection_state_notification_service.rs
  • rocketmq-store/src/index/index_service.rs
  • rocketmq-store/src/log_file/commit_log.rs
  • rocketmq-store/src/log_file/flush_manager_impl/default_flush_manager.rs
  • rocketmq-store/src/log_file/flush_manager_impl/group_commit_request.rs
  • rocketmq-store/src/log_file/mapped_file/default_mapped_file_impl.rs
  • rocketmq-store/src/log_file/mapped_file/reference_resource.rs
  • rocketmq-store/src/message_store/local_file_message_store.rs
  • rocketmq-store/src/timer/timer_message_store.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/auth/copy_acl_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/auth/copy_users_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/auth/create_acl_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/auth/create_user_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/auth/delete_acl_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/auth/delete_user_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/auth/get_acl_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/auth/get_user_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/auth/list_acl_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/auth/list_users_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/auth/update_acl_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/auth/update_user_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/broker/broker_consume_stats_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/broker/broker_status_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/broker/clean_expired_cq_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/broker/clean_unused_topic_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/broker/commit_log_set_read_ahead_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/broker/delete_expired_commit_log_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/broker/get_broker_config_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/broker/get_broker_epoch_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/broker/get_cold_data_flow_ctr_info_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/broker/remove_cold_data_flow_ctr_group_config_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/broker/reset_master_flush_offset_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/broker/send_msg_status_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/broker/switch_timer_engine_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/broker/update_broker_config_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/broker/update_cold_data_flow_ctr_group_config_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/cluster/cluster_list_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/cluster/cluster_send_msg_rt_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/connection/consumer_connection_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/connection/producer_connection_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/consumer/consumer_status_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/consumer/consumer_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/consumer/delete_subscription_group_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/consumer/set_consume_mode_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/consumer/update_sub_group_list_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/consumer/update_sub_group_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/controller/clean_broker_metadata_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/controller/get_controller_config_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/controller/get_controller_metadata_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/controller/update_controller_config_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/export/export_configs_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/export/export_metadata_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/export/export_pop_record_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/ha/get_sync_state_set_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/ha/ha_status_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/lite/get_broker_lite_info_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/namesrv/add_write_perm_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/namesrv/delete_kv_config_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/namesrv/get_namesrv_config_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/namesrv/update_kv_config_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/namesrv/update_namesrv_config_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/namesrv/wipe_write_perm_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/offset/reset_offset_by_time_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/topic/delete_topic_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/topic/remapping_static_topic_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/topic/topic_cluster_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/topic/topic_list_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/topic/topic_route_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/topic/topic_status_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/topic/update_order_conf_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/topic/update_static_topic_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/topic/update_topic_list_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/topic/update_topic_perm_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/commands/topic/update_topic_sub_command.rs
  • rocketmq-tools/rocketmq-admin/rocketmq-admin-core/src/core/admin.rs

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch enh-6539

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 29.28177% with 256 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.11%. Comparing base (8277e91) to head (86872c8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../processor/processor_service/pop_revive_service.rs 14.28% 12 Missing ⚠️
rocketmq-store/src/ha/default_ha_connection.rs 0.00% 9 Missing ⚠️
...ion/queue/default_transactional_message_service.rs 0.00% 8 Missing ⚠️
rocketmq-broker/src/broker_runtime.rs 0.00% 6 Missing ⚠️
...ssor/processor_service/pop_buffer_merge_service.rs 14.28% 6 Missing ⚠️
...q-broker/src/processor/recall_message_processor.rs 0.00% 6 Missing ⚠️
...umer/consumer_impl/re_balance/rebalance_service.rs 0.00% 6 Missing ⚠️
rocketmq-store/src/ha/default_ha_client.rs 0.00% 5 Missing ⚠️
...src/ha/ha_connection_state_notification_service.rs 0.00% 5 Missing ⚠️
...ommands/cluster/cluster_send_msg_rt_sub_command.rs 0.00% 5 Missing ⚠️
... and 124 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6540      +/-   ##
==========================================
+ Coverage   42.08%   42.11%   +0.02%     
==========================================
  Files         950      950              
  Lines      132663   132721      +58     
==========================================
+ Hits        55837    55894      +57     
- Misses      76826    76827       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@rocketmq-rust-bot rocketmq-rust-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - All CI checks passed ✅

@rocketmq-rust-bot rocketmq-rust-bot merged commit c13a53f into main Feb 27, 2026
18 of 19 checks passed
@rocketmq-rust-bot rocketmq-rust-bot added approved PR has approved and removed ready to review waiting-review waiting review this PR labels Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement✨] TimeUtils usage to replace get_current_millis with current_millis for consistency

3 participants