chore(broker): remove dead code in pull_request_hold_service

[srpvpn]

Fix #6579

Summary by CodeRabbit

• Chores
  • Improved diagnostic logging capabilities in message queue services for enhanced system observability.

[rocketmq-rust-bot]

🔊@srpvpn 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 88aea5b and eab6aeb.

📒 Files selected for processing (2)

• CHANGELOG.md
• rocketmq-broker/src/long_polling/long_polling_service/pull_request_hold_service.rs

💤 Files with no reviewable changes (1)

• rocketmq-broker/src/long_polling/long_polling_service/pull_request_hold_service.rs

---

Walkthrough

This change uncomments a previously disabled information log statement in the pull request hold service that logs when processing each topic and queue combination. The corresponding changelog entry documents this removal of dead commented-out code.

Changes

Cohort / File(s)	Summary
Code Cleanup rocketmq-broker/src/long_polling/long_polling_service/pull_request_hold_service.rs	Uncommented an information log statement in check_hold_request to enable logging of key processing (topic and queue_id); removed 4 lines of commented-out dead code.
Documentation CHANGELOG.md	Added changelog entry documenting the removal of commented-out dead logging code.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A log once lost in comments deep,
Now awakens from its sleep,
With a simple uncomment's grace,
Dead code removed—a cleaner place!
The changelog sings our rabbit's song. 🌟

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing dead code from pull_request_hold_service, which aligns with the actual removal of commented-out logging code.
Linked Issues check	✅ Passed	The pull request addresses the linked issue #6579 requirement to remove useless/dead code from pull_request_hold_service.rs by removing the commented-out log statement.
Out of Scope Changes check	✅ Passed	All changes are in-scope: the commented code removal in pull_request_hold_service.rs and the corresponding changelog entry directly address the linked issue requirement.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.84%. Comparing base (88aea5b) to head (eab6aeb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6587   +/-   ##
=======================================
  Coverage   41.84%   41.84%           
=======================================
  Files         956      956           
  Lines      133557   133557           
=======================================
+ Hits        55882    55884    +2     
+ Misses      77675    77673    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rocketmq-rust-bot]

LGTM - All CI checks passed ✅

[mxsm]

LGTM