Skip to content

Rename get_tags_ref to tags_ref for consistency#6610

Merged
mxsm merged 1 commit intomxsm:mainfrom
04cb:fix/rename-get-tags-ref
Mar 1, 2026
Merged

Rename get_tags_ref to tags_ref for consistency#6610
mxsm merged 1 commit intomxsm:mainfrom
04cb:fix/rename-get-tags-ref

Conversation

@04cb
Copy link
Contributor

@04cb 04cb commented Mar 1, 2026

Fixes #6553. Renames get_tags_ref to tags_ref for improved clarity and consistency with Rust naming conventions.

Summary by CodeRabbit

  • Refactor
    • Updated naming convention for message property accessor methods to improve API consistency.

@rocketmq-rust-bot
Copy link
Collaborator

🔊@04cb 🚀Thanks for your contribution🎉!

💡CodeRabbit(AI) will review your code first🔥!

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 67303d8 and 171e0f5.

📒 Files selected for processing (1)
  • rocketmq-common/src/common/message.rs

Walkthrough

A public method in the MessageTrait trait is renamed from get_tags_ref to tags_ref for improved naming clarity. The underlying implementation and functionality remain unchanged. This is a breaking API change affecting the trait signature.

Changes

Cohort / File(s) Summary
Method Rename
rocketmq-common/src/common/message.rs
Renamed public trait method get_tags_ref() to tags_ref() for improved API clarity. No behavior changes to the underlying implementation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A little hop, a method rename so neat,
From "get_tags_ref" to "tags_ref"—simpler to greet!
No logic changed, just clarity's gain,
A cleaner API without the refrain.
Hopping onward to brighter code terrain! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title directly and clearly summarizes the main change: renaming get_tags_ref to tags_ref for consistency.
Linked Issues check ✅ Passed The pull request successfully implements the coding requirement from issue #6553 by renaming the get_tags_ref method to tags_ref in the MessageTrait to improve clarity and align with Rust naming conventions.
Out of Scope Changes check ✅ Passed The pull request contains only the method rename from get_tags_ref to tags_ref as specified in issue #6553, with no additional out-of-scope changes introduced.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 41.52%. Comparing base (67303d8) to head (171e0f5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rocketmq-common/src/common/message.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6610   +/-   ##
=======================================
  Coverage   41.52%   41.52%           
=======================================
  Files         961      961           
  Lines      134645   134645           
=======================================
+ Hits        55905    55907    +2     
+ Misses      78740    78738    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@rocketmq-rust-bot rocketmq-rust-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - All CI checks passed ✅

Copy link
Owner

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@04cb Thanks for your contribution, LGTM

@mxsm mxsm merged commit c803c98 into mxsm:main Mar 1, 2026
11 of 21 checks passed
@rocketmq-rust-bot rocketmq-rust-bot added approved PR has approved and removed ready to review waiting-review waiting review this PR labels Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement✨] Rename get_tags_ref to tags_ref for improved clarity in message handling

4 participants