Use the duplicated logger and explain why

Author: jeffgbutler

eclipse/org.mybatis.generator.eclipse.ui/antsrc/org/mybatis/generator/eclipse/ui/ant/logging/AntLogFactory.java

@@ -20,13 +20,13 @@
 
 import org.mybatis.generator.eclipse.ui.ant.logging.commons.JakartaCommonsLoggingLogFactory;
 import org.mybatis.generator.eclipse.ui.ant.logging.log4j2.Log4j2LoggingLogFactory;
+import org.mybatis.generator.eclipse.ui.ant.logging.slf4j.Slf4jLoggingLogFactory;
 import org.mybatis.generator.eclipse.ui.launcher.tabs.LoggingButtonData;
 import org.mybatis.generator.logging.AbstractLogFactory;
 import org.mybatis.generator.logging.Log;
 import org.mybatis.generator.logging.LogException;
 import org.mybatis.generator.logging.jdk14.Jdk14LoggingLogFactory;
 import org.mybatis.generator.logging.nologging.NoLoggingLogFactory;
-import org.mybatis.generator.logging.slf4j.Slf4jLoggingLogFactory;
 
 /**
  * Factory for creating loggers

eclipse/org.mybatis.generator.eclipse.ui/antsrc/org/mybatis/generator/eclipse/ui/ant/logging/package-info.java

@@ -19,8 +19,15 @@
  * in the base MyBatis Generator code.  We need to duplicate them in the Eclipse plugin Ant runner
  * because of some complexities in plugin class loading.
  * <p>
- * We don't want the optional logging frameworks to always be on the plugin classpath.  And the plugin
- * classpath cannot be altered at runtime.  And the plugin classloader is a parent of the Ant classloader.
+ * Classes in the antsupport JAR are loaded by the Ant classloader - which is a child of the plugin classloader.
+ * 
+ * Only the Ant classloader will have the logging implementations that are added to the launch configuration
+ * classpath.
+ * 
+ * Any class that uses one of the optional logging implementations must also be loaded by the Ant classloader.
+ * If we use the versions from the base library (loaded by the plugin classloader), they will not be able to see
+ * the implementation JARs.
+ * 
  * All of this combines to mean that we need the logging implementations that have optional dependencies
  * to be loaded by the Ant classloader, rather than the plugin classloader - so we need them in this source
  * JAR rather than the main plugin JAR.