Merged
Conversation
Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>
Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix compatibility issues with Agroal library and upgrade version
Upgrade agroal from 2.2 to 3.0
Feb 8, 2026
hazendaz
reviewed
Feb 8, 2026
Member
hazendaz
left a comment
There was a problem hiding this comment.
Work is excellent. Watching AI take this task on and accomplishing it is nothing less than amazing. There was an unfortunate side effect with license plugin which I followed up with AI on why and have reported that to the plugin maintainers, of which I am one. I anticipate we will get support to skip shallow clones involvement in the future. Since AI was able to keep the changes separate, I'm accepting this hard problem it solved here without rework.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Agroal 2.3+ enforces JTA spec: only one "last resource" per transaction. Tests used two local datasources in same transaction—both attempting last resource registration—causing failures.
Solution
Mixed XA + connectable local datasource pattern:
Derby (JtaLocalTest)
HSQLDB (SimpleJTATest)
Changes
createXADataSource()now usesEmbeddedXADataSourcewithxaProperty()configurationcreateLocalDataSource()enables connectable mode for LRCOJDBCXADataSourcefor HSQLDBNotes
License headers updated 2025→2026 by
license-maven-plugindue to shallow clone workflow making all files appear modified in 2026.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.