Skip to content

Conversation

remeio
Copy link
Contributor

@remeio remeio commented Apr 16, 2023

fix issue #2587

@remeio remeio force-pushed the fix_doc_language_of_ko branch from da1f9db to 947001a Compare April 16, 2023 14:11
@harawata
Copy link
Member

Thank you @remeio ,

But these links are for people who cannot read Korean.
https://mybatis.org/mybatis-3/
https://mybatis.org/mybatis-3/zh/
So, it's not appropriate to translate.

@harawata
Copy link
Member

harawata commented Jun 19, 2025

Hi @remeio ,

My comment does not match the change in this PR, so I must have misunderstood something.
Could you submit a new PR? (as the branch is deleted, we cannot reopen this one)

@remeio remeio restored the fix_doc_language_of_ko branch June 21, 2025 09:59
@remeio
Copy link
Contributor Author

remeio commented Jun 21, 2025

Hi @remeio ,

My comment does not match the change in this PR, so I must have misunderstood something. Could you submit a new PR? (as the branch is deleted, we cannot reopen this one)

Hi. I had restored this branch fix_doc_language_of_ko.

@harawata harawata reopened this Jun 21, 2025
@remeio
Copy link
Contributor Author

remeio commented Jun 21, 2025

Hi, I will commit a new PR to resolve conflict. Wait a moment.

@harawata
Copy link
Member

@remeio ,

Sorry, the target file has been migrated to Markdown format a while ago.
https://github.com/mybatis/mybatis-3/blob/729aed778b017f546e425c4193d2669efe897a58/src/site/ko/markdown/index.md

Can you make the same change to that file instead?

@remeio
Copy link
Contributor Author

remeio commented Jun 21, 2025

You can close this PR. See more at #3491.

@harawata harawata closed this Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants