Closed
Conversation
Member
|
I expressed my concern about allowing direct access to the wrapped instances. |
a795b01 to
bc5c175
Compare
bc5c175 to
0379d03
Compare
Contributor
Author
|
Member
Member
|
Will circle back on this in some time. I think the general idea was that users wanted it and I believe I suggested it was ok to create new PR bringing others up to date. I do not have any strong preference either way. |
Contributor
Author
|
keep loosely coupled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopen from #838 and related #2921