Skip to content

Conversation

nieqiurong
Copy link
Contributor

If the transaction is committed, rollback will be invalid.
It's better to put the transaction rollback operation into the exception block

@coveralls
Copy link

Coverage Status

coverage: 87.256% (+0.02%) from 87.235%
when pulling e88ddb1 on nieqiurong:20250312130529
into 1a145cd on mybatis:master.

@harawata
Copy link
Member

harawata commented Mar 14, 2025

Hello @nieqiurong ,

These tests are passing without the change (there should be a test case that requires the proposed change to pass).

FYI, here is the Javadoc comment of ScriptRunner.

This is an internal testing utility.
You are welcome to use this class for your own purposes,
but if there is some feature/enhancement you need for your own usage,
please make and modify your own copy instead of sending us an enhancement request.

So, unless this fixes an obvious bug, we may reject the PR.
Personally, I really really want to move this class to src/test/.

@nieqiurong
Copy link
Contributor Author

This is not a defect, it's just a misunderstanding when reading

@nieqiurong nieqiurong closed this Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants