Open
Conversation
harlamenko
pushed a commit
to harlamenko/chartjs-plugin-piechart-outlabels
that referenced
this pull request
Aug 8, 2024
Reorganizes sample files, in order to make the sample visible on Netlify. - `index.html` is moved to root directory in order to make the Netlify configuration simpler. It's also more compatible to some builders like Vite (see https://vitejs.dev/guide/#index-html-and-project-root) - Remove external libraries copied in the repo, use jscolor from CDN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One solution for #2
This PR moves labels to the left and down, instead of up off the screen.
NOTE: This PR has some things specific to our needs, so it may not be ready to merge as a generic solution. The things that might be specific to us:
Even though this is probably not generic enough for everyone, I'm submitting this PR as it may help someone and give the maintainers ideas how to solve this bug.