-
Notifications
You must be signed in to change notification settings - Fork 324
feat: update Sidepad (focus, right position...) #1353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…tem and fix when it's on a second screen that has different width
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds configurable positioning for the sidepad feature, allowing users to choose between left or right side placement. It also improves multi-monitor support by using monitor-relative coordinates and implements automatic focus management.
Key changes:
- Added
--positionparameter to configure sidepad placement (left/right) - Implemented focus saving/restoration when hiding/showing the sidepad
- Fixed multi-monitor positioning by using monitor-specific X/Y coordinates
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| dotfiles/.config/sidepad/sidepad | Core script updated with position-aware calculations, monitor-relative coordinates, and focus management |
| dotfiles/.config/ml4w/settings/sidepad-position | New configuration file storing default position ("left") |
| dotfiles/.config/ml4w/scripts/sidepad.sh | Wrapper script updated to load and pass position configuration to the core script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for this PR. The launch of 2.9.9.5 is planned already for this weekend. I will test it for 2.9.9.6 |
|
Yes sure, you tell me if you want me to modify something :) |
Description
This pull request adds the ability to configure the Sidepad position (Left or Right), improves multi-monitor support, and enhances focus management for a smoother workflow.
Changes
Context
How Has This Been Tested?
(Cochez la case correspondant à votre distribution)
Checklist
Please ensure your pull request meets the following requirements:
Screenshots
Related Issues
Fixes #1261
Additional Notes
Key Features:
left).--move-leftand--move-rightarguments. If the sidepad is on the right, the logic is inverted so that moving towards the edge always hides it, and moving towards the center opens it./tmp/sidepad-prev-focuswhen opening, and restores focus to that window when closing.x,y,width, andheightof the monitor where the sidepad is located, fixing issues on mixed-resolution setups.