Allow hostname without github-runner prefix to avoid 64-char limit #465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Allow runner name to use hostname without the
github-runner-prefix to avoid exceeding GitHub's 64-character limit for runner names.Problem Description
Currently, the runner name generation logic in [entrypoint.sh](https://github.com/myoung34/docker-github-actions-runner/blob/master/entrypoint.sh#L45) always includes a prefix when using the hostname, which can cause the total runner name to exceed GitHub's 64-character limit.
The hostname length can be controlled by the consumer to be up to 64 characters, but the prefix may cause the limit to be exceeded, resulting in the runner failing to be created with the following error:
An error occurred: Not configured. Run config.(sh/cmd) to configure the runner.This is problematic in cases where:
github-runner-(14 characters) + hostname would exceed the 64-character limitRUNNER_NAME_PREFIXis empty