Fixed various sketch-specific warnings

Author: fallberg

libraries/MySensors/examples/DimmableLightWithRotaryEncoderButton/DimmableLightWithRotaryEncoderButton.ino

@@ -133,7 +133,7 @@ void incomingMessage(const MyMessage &message)
       newLevel = loadLevelState(EEPROM_DIM_LEVEL_SAVE);
     } 
     // Send dimmer level back to controller with ack enabled
-    gw.send(dimmerMsg.set(0), true);
+    gw.send(dimmerMsg.set(newLevel), true);
     // We do not change any levels here until ack comes back from gateway 
     return;
   } else if (message.type == V_DIMMER) {

libraries/MySensors/examples/DistanceSensor/DistanceSensor.ino

@@ -51,7 +51,7 @@ void setup()
 
   // Register all sensors to gw (they will be created as child devices)
   gw.present(CHILD_ID, S_DISTANCE);
-  boolean metric = gw.getConfig().isMetric;
+  metric = gw.getConfig().isMetric;
 }
 
 void loop()      

libraries/MySensors/examples/LightningSensor/LightningSensor.ino

@@ -42,7 +42,6 @@ void setup()
   // Register all sensors to gw (they will be created as child devices)
   gw.present(CHILD_ID_DISTANCE, S_DISTANCE);
   gw.present(CHILD_ID_INTENSITY, S_CUSTOM);
-  boolean metric = gw.getConfig().isMetric;
 
   Serial.begin(115200);
   Serial.println("Playing With Fusion: AS3935 Lightning Sensor, SEN-39001");
@@ -118,4 +117,4 @@ void loop()
 void AS3935_ISR()
 {
   AS3935_ISR_Trig = 1;
-}
+}

libraries/MySensors/examples/MQTTGateway/MQTTGateway.ino

@@ -279,6 +279,7 @@ void processMQTTMessage(char *inputString, uint8_t inputPos) {
 	uint8_t i = 0;
 	buffer[0]= 0;
 	buffsize = 0;
+	(void)inputPos;
 
 	if ((uint8_t)inputString[0] >> 4 == MQTTCONNECT) {
 		buffer[buffsize++] = MQTTCONNACK << 4;
@@ -336,7 +337,7 @@ void processMQTTMessage(char *inputString, uint8_t inputPos) {
 			} else if (i==2) {
 				msg.sensor = atoi(str);		//SensorID
 			} else if (i==3) {
-				char match=255;			//SensorType
+				unsigned char match=255;			//SensorType
 #ifdef MQTT_TRANSLATE_TYPES				
 
 				for (uint8_t j=0; strcpy_P(convBuf, (char*)pgm_read_word(&(vType[j]))) ; j++) {
@@ -348,7 +349,7 @@ void processMQTTMessage(char *inputString, uint8_t inputPos) {
 				}
 
 #endif
-                                if ( atoi(str)!=0 || str=="0" ) {
+                                if ( atoi(str)!=0 || (str[0]=='0' && str[1] =='\0') ) {
 					match=atoi(str);
 				}
 

libraries/MySensors/examples/RainGauge/RainGauge.ino

@@ -123,7 +123,7 @@ volatile int wasTippedBuffer = 0;
 int rainSensorThreshold = 50; //default rain sensor sensitivity in hundredths.  Will be overwritten with msgTrippedVar2.
 byte state = 0;
 byte oldState = -1;
-int lastRainRate = 0;
+unsigned int lastRainRate = 0;
 int lastMeasure = 0;
 boolean gotTime = false;
 byte lastHour;

libraries/MySensors/examples/RealTimeClockDisplaySensor/RealTimeClockDisplaySensor.ino

@@ -88,8 +88,8 @@ void loop()
 
   // If no time has been received yet, request it every 10 second from controller
   // When time has been received, request update every hour
-  if ((!timeReceived && now-lastRequest > (unsigned long)(10*1000))
-    || (timeReceived && now-lastRequest > (unsigned long)(60*1000*60))) {
+  if ((!timeReceived && (now-lastRequest) > (10UL*1000UL))
+    || (timeReceived && (now-lastRequest) > (60UL*1000UL*60UL))) {
     // Request time from controller. 
     Serial.println("requesting time");
     gw.requestTime(receiveTime);  

libraries/MySensors/examples/SecretKnockSensor/SecretKnockSensor.ino

@@ -298,7 +298,6 @@ boolean validateKnock(){
 // reads the secret knock from EEPROM. (if any.)
 void readSecretKnock(){
   byte reading;
-  int i;
   reading = gw.loadState(1);
   if (reading == eepromValid){    // only read EEPROM if the signature byte is correct.
     for (int i=0; i < maximumKnocks ;i++){

libraries/MySensors/examples/SecureActuator/SecureActuator.ino

@@ -71,7 +71,7 @@ MySigningAtsha204 signer;
 #endif
 MySensor gw(radio, hw, signer);
 #else
-#warning SecureActuator cannot possibly be secure without signing enabled
+// WARNING! SecureActuator cannot possibly be secure without signing enabled
 MySensor gw(radio, hw);
 #endif
 

libraries/MySensors/examples/Sha204Personalizer/Sha204Personalizer.ino

@@ -237,7 +237,6 @@ void write_key(uint8_t* key)
 
 void dump_configuration()
 {
-  uint8_t config_word[4];
   uint8_t tx_buffer[SHA204_CMD_SIZE_MAX];
   uint8_t rx_buffer[SHA204_RSP_SIZE_MAX];
   uint8_t ret_code;
@@ -682,6 +681,8 @@ void setup()
   uint8_t lockConfig = 0;
   uint8_t lockValue = 0;
   uint16_t crc;
+  (void)crc;
+
   Serial.begin(115200);
 
   Serial.println(F("ATSHA204 personalization sketch for MySensors usage."));

libraries/MySensors/examples/TimeAwareSensor/TimeAwareSensor.ino

@@ -59,8 +59,8 @@ void loop()
 
    // If no time has been received yet, request it every 10 second from controller
   // When time has been received, request update every hour
-  if ((!timeReceived && now-lastRequest > 10*1000)
-    || (timeReceived && now-lastRequest > 60*1000*60)) {
+  if ((!timeReceived && (now-lastRequest) > (10UL*1000UL))
+    || (timeReceived && (now-lastRequest) > (60UL*1000UL*60UL))) {
     // Request time from controller. 
     Serial.println("requesting time");
     gw.requestTime(receiveTime);