Added a warning about incorrect flags being used#1425
Added a warning about incorrect flags being used#1425Avamander wants to merge 1 commit intomysensors:developmentfrom Avamander:patch-3
Conversation
Made the preprocessor throw an error if an ancient define is specified, user must update their defines to avoid very difficult to diagnose issues further on.
|
I did some digging and the names were changed in the release of 2.0.0 (1.5.4 which was the last 1.x release had the old variants without MY_) The commit was f8ee376 In the same commit, these were also updated so maybe these should have deprecation warnings as well: I checked keywords.txt and none of the old defines have highlighting rules. |
|
Yeah, probably would be a good idea. It probably wouldn't be a bad idea to just have a section in MyConfig.h that's for all the deprecated flags that throw errors. |
|
There is a list at https://www.mysensors.org/apidocs/deprecated.html but that page only lists stuff that have ben annotated as deprecated. |
|
I more meant like that the file itself could have a separate section, so they aren't all mixed up with the rest, valid defined. I think that should be some other PR that does that though. |
Made the preprocessor throw an error if an ancient define is specified, user must update their defines to avoid very difficult to diagnose issues further on.
I personally stumbled upon it. I hope this PR avoids the headache for someone else.