Suppress the warnings about missing loggers for elasticsearch#1596
Merged
Suppress the warnings about missing loggers for elasticsearch#1596
Conversation
If there are no loggers defined for the elasticsearch Python package you get errors like the following: No handlers could be found for logger "elasticsearch" (in production) No handlers could be found for logger "elasticsearch.trace" (local dev) (I'm not sure why there's that difference in those logger names.) This commit sets up loggers for both names in the Django settings module that will send any logging of level INFO and above to standard error. This suppresses that warning and should mean that we're able to see real warnings and errors in the logs.
Now that elasticsearch warnings are being sent to standard error, this one has become apparent: List of nodes should not include schema information (http://): 'http://127.0.0.1:9200'. ... which can be fixed by removing the schema from the URL in HAYSTACK_CONNECTIONS.
Member
|
It appears that the logging message being generated and causing the error is: This was fixed in elastic/elasticsearch-py#149 and the latest version of In any case, this PR LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are no loggers defined for the elasticsearch Python package you
get errors like the following:
No handlers could be found for logger "elasticsearch" (in production)
No handlers could be found for logger "elasticsearch.trace" (local dev)
(I'm not sure why there's that difference in those logger names.)
This commit sets up loggers for both names in the Django settings module
that will send any logging of level INFO and above to standard error.
This suppresses that warning and should mean that we're able to see
real warnings and errors in the logs.