Suppress CA2012 for safe uses of ValueTask.

ValueTask.GetAwaiter().GetResult() is only called on ValueTasks known to have completed synchronously.

Author: bgrainger

src/MySqlConnector/Core/ServerSession.cs

@@ -278,8 +278,10 @@ public void FinishQuerying()
 				// See https://bugs.mysql.com/bug.php?id=45679
 				Log.Info("Session{0} sending 'DO SLEEP(0)' command to clear pending cancellation", m_logArguments);
 				var payload = QueryPayload.Create("DO SLEEP(0);");
+#pragma warning disable CA2012 // Safe because method completes synchronously
 				SendAsync(payload, IOBehavior.Synchronous, CancellationToken.None).GetAwaiter().GetResult();
 				payload = ReceiveReplyAsync(IOBehavior.Synchronous, CancellationToken.None).GetAwaiter().GetResult();
+#pragma warning restore CA2012
 				OkPayload.Create(payload.Span, SupportsDeprecateEof, SupportsSessionTrack);
 			}
 

src/MySqlConnector/MySqlBulkCopy.cs

@@ -102,7 +102,9 @@ public MySqlBulkCopy(MySqlConnection connection, MySqlTransaction? transaction =
 		public void WriteToServer(DataTable dataTable)
 		{
 			m_valuesEnumerator = DataRowsValuesEnumerator.Create(dataTable ?? throw new ArgumentNullException(nameof(dataTable)));
+#pragma warning disable CA2012 // Safe because method completes synchronously
 			WriteToServerAsync(IOBehavior.Synchronous, CancellationToken.None).GetAwaiter().GetResult();
+#pragma warning restore CA2012
 		}
 
 #if NET45 || NET461 || NET471 || NETSTANDARD1_3 || NETSTANDARD2_0
@@ -140,7 +142,9 @@ public async ValueTask WriteToServerAsync(DataTable dataTable, CancellationToken
 		public void WriteToServer(IEnumerable<DataRow> dataRows, int columnCount)
 		{
 			m_valuesEnumerator = new DataRowsValuesEnumerator(dataRows ?? throw new ArgumentNullException(nameof(dataRows)), columnCount);
+#pragma warning disable CA2012 // Safe because method completes synchronously
 			WriteToServerAsync(IOBehavior.Synchronous, CancellationToken.None).GetAwaiter().GetResult();
+#pragma warning restore CA2012
 		}
 #if NET45 || NET461 || NET471 || NETSTANDARD1_3 || NETSTANDARD2_0
 		/// <summary>
@@ -183,8 +187,11 @@ public async ValueTask WriteToServerAsync(IEnumerable<DataRow> dataRows, int col
 		public void WriteToServer(IDataReader dataReader)
 		{
 			m_valuesEnumerator = DataReaderValuesEnumerator.Create(dataReader ?? throw new ArgumentNullException(nameof(dataReader)));
+#pragma warning disable CA2012 // Safe because method completes synchronously
 			WriteToServerAsync(IOBehavior.Synchronous, CancellationToken.None).GetAwaiter().GetResult();
+#pragma warning restore CA2012
 		}
+
 #if NET45 || NET461 || NET471 || NETSTANDARD1_3 || NETSTANDARD2_0
 		/// <summary>
 		/// Asynchronously copies all rows in the supplied <see cref="IDataReader"/> to the destination table specified by the

src/MySqlConnector/MySqlBulkLoader.cs

@@ -149,7 +149,9 @@ public MySqlBulkLoader(MySqlConnection connection)
 		/// Loads all data in the source file or stream into the destination table.
 		/// </summary>
 		/// <returns>The number of rows inserted.</returns>
+#pragma warning disable CA2012 // Safe because method completes synchronously
 		public int Load() => LoadAsync(IOBehavior.Synchronous, CancellationToken.None).GetAwaiter().GetResult();
+#pragma warning restore CA2012
 
 		/// <summary>
 		/// Asynchronously loads all data in the source file or stream into the destination table.

src/MySqlConnector/MySqlConnection.cs

@@ -34,6 +34,7 @@ public MySqlConnection(string? connectionString)
 			m_connectionString = connectionString ?? "";
 		}
 
+#pragma warning disable CA2012 // Safe because method completes synchronously
 		/// <summary>
 		/// Begins a database transaction.
 		/// </summary>
@@ -64,6 +65,7 @@ public MySqlConnection(string? connectionString)
 		/// <param name="isolationLevel">The <see cref="IsolationLevel"/> for the transaction.</param>
 		/// <returns>A <see cref="MySqlTransaction"/> representing the new database transaction.</returns>
 		protected override DbTransaction BeginDbTransaction(IsolationLevel isolationLevel) => BeginTransactionAsync(isolationLevel, default, IOBehavior.Synchronous, default).GetAwaiter().GetResult();
+#pragma warning restore CA2012
 
 #if NET45 || NET461 || NET471 || NETSTANDARD1_3 || NETSTANDARD2_0 || NETCOREAPP2_1
 		/// <summary>
@@ -353,7 +355,9 @@ private async Task ChangeDatabaseAsync(IOBehavior ioBehavior, string databaseNam
 
 		public new MySqlCommand CreateCommand() => (MySqlCommand)base.CreateCommand();
 
+#pragma warning disable CA2012 // Safe because method completes synchronously
 		public bool Ping() => PingAsync(IOBehavior.Synchronous, CancellationToken.None).GetAwaiter().GetResult();
+#pragma warning restore CA2012
 		public Task<bool> PingAsync(CancellationToken cancellationToken = default) => PingAsync(SimpleAsyncIOBehavior, cancellationToken).AsTask();
 
 		private async ValueTask<bool> PingAsync(IOBehavior ioBehavior, CancellationToken cancellationToken)
@@ -524,6 +528,7 @@ private static async Task ClearPoolAsync(MySqlConnection connection, IOBehavior
 #if !NETSTANDARD1_3
 		protected override DbProviderFactory DbProviderFactory => MySqlConnectorFactory.Instance;
 
+#pragma warning disable CA2012 // Safe because method completes synchronously
 		/// <summary>
 		/// Returns schema information for the data source of this <see cref="MySqlConnection"/>.
 		/// </summary>
@@ -544,6 +549,7 @@ private static async Task ClearPoolAsync(MySqlConnection connection, IOBehavior
 		/// <param name="restrictionValues">The restrictions to apply to the schema; this parameter is currently ignored.</param>
 		/// <returns>A <see cref="DataTable"/> containing schema information.</returns>
 		public override DataTable GetSchema(string collectionName, string?[] restrictionValues) => GetSchemaProvider().GetSchemaAsync(IOBehavior.Synchronous, collectionName, default).GetAwaiter().GetResult();
+#pragma warning restore CA2012
 
 		/// <summary>
 		/// Asynchronously returns schema information for the data source of this <see cref="MySqlConnection"/>.

src/MySqlConnector/MySqlDataReader.cs

@@ -321,7 +321,9 @@ public override long GetChars(int ordinal, long dataOffset, char[]? buffer, int
 			return Task.FromResult(GetSchemaTable());
 		}
 
+#pragma warning disable CA2012 // Safe because method completes synchronously
 		public override void Close() => DisposeAsync(IOBehavior.Synchronous, CancellationToken.None).GetAwaiter().GetResult();
+#pragma warning restore CA2012
 #endif
 
 		/// <summary>
@@ -406,8 +408,10 @@ protected override void Dispose(bool disposing)
 		{
 			try
 			{
+#pragma warning disable CA2012 // Safe because method completes synchronously
 				if (disposing)
 					DisposeAsync(IOBehavior.Synchronous, CancellationToken.None).GetAwaiter().GetResult();
+#pragma warning restore CA2012
 			}
 			finally
 			{

src/MySqlConnector/MySqlTransaction.cs

@@ -180,8 +180,10 @@ protected override void Dispose(bool disposing)
 		{
 			try
 			{
+#pragma warning disable CA2012 // Safe because method completes synchronously
 				if (disposing)
 					DisposeAsync(IOBehavior.Synchronous, CancellationToken.None).GetAwaiter().GetResult();
+#pragma warning restore CA2012
 			}
 			finally
 			{