Use more static lambdas.

Author: bgrainger

src/MySqlConnector.DependencyInjection/MySqlConnectorServiceCollectionExtensions.cs

@@ -100,13 +100,13 @@ private static IServiceCollection DoAddMySqlDataSource(
 				},
 				dataSourceLifetime));
 
-		serviceCollection.TryAdd(new ServiceDescriptor(typeof(MySqlConnection), x => x.GetRequiredService<MySqlDataSource>().CreateConnection(), connectionLifetime));
+		serviceCollection.TryAdd(new ServiceDescriptor(typeof(MySqlConnection), static x => x.GetRequiredService<MySqlDataSource>().CreateConnection(), connectionLifetime));
 
 #if NET7_0_OR_GREATER
-		serviceCollection.TryAdd(new ServiceDescriptor(typeof(DbDataSource), x => x.GetRequiredService<MySqlDataSource>(), dataSourceLifetime));
+		serviceCollection.TryAdd(new ServiceDescriptor(typeof(DbDataSource), static x => x.GetRequiredService<MySqlDataSource>(), dataSourceLifetime));
 #endif
 
-		serviceCollection.TryAdd(new ServiceDescriptor(typeof(DbConnection), x => x.GetRequiredService<MySqlConnection>(), connectionLifetime));
+		serviceCollection.TryAdd(new ServiceDescriptor(typeof(DbConnection), static x => x.GetRequiredService<MySqlConnection>(), connectionLifetime));
 
 		return serviceCollection;
 	}
@@ -133,13 +133,13 @@ private static IServiceCollection DoAddMySqlDataSource(
 				},
 				dataSourceLifetime));
 
-		serviceCollection.TryAdd(new ServiceDescriptor(typeof(MySqlConnection), serviceKey, (sp, sk) => sp.GetRequiredKeyedService<MySqlDataSource>(sk).CreateConnection(), connectionLifetime));
+		serviceCollection.TryAdd(new ServiceDescriptor(typeof(MySqlConnection), serviceKey, static (sp, sk) => sp.GetRequiredKeyedService<MySqlDataSource>(sk).CreateConnection(), connectionLifetime));
 
 #if NET7_0_OR_GREATER
-		serviceCollection.TryAdd(new ServiceDescriptor(typeof(DbDataSource), serviceKey, (sp, sk) => sp.GetRequiredKeyedService<MySqlDataSource>(sk), dataSourceLifetime));
+		serviceCollection.TryAdd(new ServiceDescriptor(typeof(DbDataSource), serviceKey, static (sp, sk) => sp.GetRequiredKeyedService<MySqlDataSource>(sk), dataSourceLifetime));
 #endif
 
-		serviceCollection.TryAdd(new ServiceDescriptor(typeof(DbConnection), serviceKey, (sp, sk) => sp.GetRequiredKeyedService<MySqlConnection>(sk), connectionLifetime));
+		serviceCollection.TryAdd(new ServiceDescriptor(typeof(DbConnection), serviceKey, static (sp, sk) => sp.GetRequiredKeyedService<MySqlConnection>(sk), connectionLifetime));
 
 		return serviceCollection;
 	}

src/MySqlConnector/Core/MetricsReporter.cs

@@ -39,10 +39,10 @@ static MetricsReporter()
 			description: "The maximum number of open connections allowed; this corresponds to MaximumPoolSize in the connection string.");
 
 		static IEnumerable<Measurement<int>> GetMaximumConnections() =>
-			ConnectionPool.GetAllPools().Select(x => new Measurement<int>(x.ConnectionSettings.MaximumPoolSize, x.PoolNameTagList));
+			ConnectionPool.GetAllPools().Select(static x => new Measurement<int>(x.ConnectionSettings.MaximumPoolSize, x.PoolNameTagList));
 
 		static IEnumerable<Measurement<int>> GetMinimumConnections() =>
-			ConnectionPool.GetAllPools().Select(x => new Measurement<int>(x.ConnectionSettings.MinimumPoolSize, x.PoolNameTagList));
+			ConnectionPool.GetAllPools().Select(static x => new Measurement<int>(x.ConnectionSettings.MinimumPoolSize, x.PoolNameTagList));
 	}
 
 	private static readonly UpDownCounter<int> s_connectionsUsageCounter = ActivitySourceHelper.Meter.CreateUpDownCounter<int>("db.client.connections.usage",

src/MySqlConnector/Core/SchemaProvider.cs

@@ -391,7 +391,7 @@ await FillDataTableAsync(ioBehavior, dataTable, command =>
 #pragma warning restore CA2100
 			if (columns is { Count: > 0 })
 			{
-				command.CommandText += " WHERE " + string.Join(" AND ", columns.Select(x => $@"{x.Key} = @{x.Key}"));
+				command.CommandText += " WHERE " + string.Join(" AND ", columns.Select(static x => $@"{x.Key} = @{x.Key}"));
 				foreach (var column in columns)
 					command.Parameters.AddWithValue("@" + column.Key, column.Value);
 			}

src/MySqlConnector/Core/SingleCommandPayloadCreator.cs

@@ -35,7 +35,7 @@ public bool WriteQueryCommand(ref CommandListPosition commandListPosition, IDict
 				writer.Write((byte) 1);
 
 				if (attributes?.Count > 0)
-					WriteBinaryParameters(writer, attributes.Select(x => x.ToParameter()).ToArray(), command, true, 0);
+					WriteBinaryParameters(writer, attributes.Select(static x => x.ToParameter()).ToArray(), command, true, 0);
 			}
 			else if (command.RawAttributes?.Count > 0)
 			{

src/MySqlConnector/MySqlConnectionStringBuilder.cs

@@ -805,7 +805,7 @@ public bool UseXaTransactions
 	/// <summary>
 	/// Returns an <see cref="ICollection"/> that contains the keys in the <see cref="MySqlConnectionStringBuilder"/>.
 	/// </summary>
-	public override ICollection Keys => base.Keys.Cast<string>().OrderBy(x => MySqlConnectionStringOption.OptionNames.IndexOf(x)).ToList();
+	public override ICollection Keys => base.Keys.Cast<string>().OrderBy(static x => MySqlConnectionStringOption.OptionNames.IndexOf(x)).ToList();
 
 	/// <summary>
 	/// Whether this <see cref="MySqlConnectionStringBuilder"/> contains a set option with the specified name.
@@ -1165,7 +1165,7 @@ static MySqlConnectionStringOption()
 		AddOption(options, CancellationTimeout = new(
 			keys: ["Cancellation Timeout", "CancellationTimeout"],
 			defaultValue: 2,
-			coerce: x =>
+			coerce: static x =>
 			{
 				if (x < -1)
 					throw new ArgumentOutOfRangeException(nameof(CancellationTimeout), "CancellationTimeout must be greater than or equal to -1");