Add ConnectionOpenedCallback #1515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This differs from the existing StateChanged event in that: - it supports an async callback - it's only invoked when a connection is opened - it provides information about new vs existing and whether the connection was reset Signed-off-by: Bradley Grainger <[email protected]>
ejball
reviewed
Oct 10, 2024
Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
This will make it easier to add additional properties in the future if they're ever needed. Signed-off-by: Bradley Grainger <[email protected]>
Rename type to 'Context'; this matches the existing UsePeriodicPasswordProvider. Add CancellationToken; the user might execute commands against the server that might need to be cancelled. Remove sync overload; it could be unnecessary. Move types to their own files. Allow multiple callbacks to be added. Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
|
Thanks for this! However I'm struggling to see how this should be used when creating a |
|
Documentation isn't fully updated yet, but you need to use
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1508.
This differs from the existing
StateChangedevent in that:Opening for API review. Needs tests before it can be merged.