lint: prefer triple equal operator

Author: dougwilson

.eslintrc

@@ -5,6 +5,7 @@
   "rules": {
     "comma-dangle": [2, "never"],
     "consistent-return": 2,
+    "eqeqeq": [2, "allow-null"],
     "indent": [2, 2, { "VariableDeclarator": 2, "SwitchCase": 1 }],
     "new-parens": 2,
     "no-cond-assign": 2,

lib/Connection.js

@@ -201,7 +201,7 @@ Connection.prototype.query = function query(sql, values, cb) {
   var query = Connection.createQuery(sql, values, cb);
   query._connection = this;
 
-  if (!(typeof sql == 'object' && 'typeCast' in sql)) {
+  if (!(typeof sql === 'object' && 'typeCast' in sql)) {
     query.typeCast = this.config.typeCast;
   }
 
@@ -281,7 +281,7 @@ Connection.prototype.escapeId = function escapeId(value) {
 };
 
 Connection.prototype.format = function(sql, values) {
-  if (typeof this.config.queryFormat == 'function') {
+  if (typeof this.config.queryFormat === 'function') {
     return this.config.queryFormat.call(this, sql, values, this.config.timezone);
   }
   return SqlString.format(sql, values, this.config.stringifyObjects, this.config.timezone);

lib/ConnectionConfig.js

@@ -38,7 +38,7 @@ function ConnectionConfig(options) {
     ? true
     : options.typeCast;
 
-  if (this.timezone[0] == ' ') {
+  if (this.timezone[0] === ' ') {
     // "+" is a url encoded char for space so it
     // gets translated to space when giving a
     // connection string..

lib/Pool.js

@@ -159,7 +159,7 @@ Pool.prototype.releaseConnection = function releaseConnection(connection) {
 Pool.prototype.end = function (cb) {
   this._closed = true;
 
-  if (typeof cb != 'function') {
+  if (typeof cb !== 'function') {
     cb = function (err) {
       if (err) throw err;
     };

lib/protocol/Auth.js

@@ -40,13 +40,13 @@ Auth.hashPassword = function(password) {
       nr2 = [0x1234, 0x5671],
       result = new Buffer(8);
 
-  if (typeof password == 'string'){
+  if (typeof password === 'string'){
     password = new Buffer(password);
   }
 
   for (var i = 0; i < password.length; i++) {
     var c = password[i];
-    if (c == 32 || c == 9) {
+    if (c === 32 || c === 9) {
       // skip space in password
       continue;
     }
@@ -109,12 +109,12 @@ Auth.fmt32 = function(x){
   var a = x[0].toString(16),
       b = x[1].toString(16);
 
-  if (a.length == 1) a = '000'+a;
-  if (a.length == 2) a = '00'+a;
-  if (a.length == 3) a = '0'+a;
-  if (b.length == 1) b = '000'+b;
-  if (b.length == 2) b = '00'+b;
-  if (b.length == 3) b = '0'+b;
+  if (a.length === 1) a = '000'+a;
+  if (a.length === 2) a = '00'+a;
+  if (a.length === 3) a = '0'+a;
+  if (b.length === 1) b = '000'+b;
+  if (b.length === 2) b = '00'+b;
+  if (b.length === 3) b = '0'+b;
   return '' + a + '/' + b;
 };
 

lib/protocol/packets/Field.js

@@ -27,7 +27,7 @@ Field.prototype.geometry = function () {
 
 function typeToString(t) {
   for (var k in Types) {
-    if (Types[k] == t) return k;
+    if (Types[k] === t) return k;
   }
 
   return undefined;

lib/protocol/packets/HandshakeInitializationPacket.js

@@ -89,10 +89,10 @@ HandshakeInitializationPacket.prototype.write = function(writer) {
 
 HandshakeInitializationPacket.prototype.scrambleBuff = function() {
   var buffer = new Buffer(this.scrambleBuff1.length +
-                          (typeof this.scrambleBuff2 != 'undefined' ? this.scrambleBuff2.length : 0));
+                          (typeof this.scrambleBuff2 !== 'undefined' ? this.scrambleBuff2.length : 0));
 
   this.scrambleBuff1.copy(buffer);
-  if (typeof this.scrambleBuff2 != 'undefined') {
+  if (typeof this.scrambleBuff2 !== 'undefined') {
     this.scrambleBuff2.copy(buffer, this.scrambleBuff1.length);
   }
 

lib/protocol/packets/RowDataPacket.js

@@ -29,7 +29,7 @@ function parse(parser, fieldPackets, typeCast, nestTables, connection) {
     var fieldPacket = fieldPackets[i];
     var value;
 
-    if (typeof typeCast == 'function') {
+    if (typeof typeCast === 'function') {
       value = typeCast.apply(connection, [ new Field({ packet: fieldPacket, parser: parser }), next ]);
     } else {
       value = (typeCast)
@@ -39,7 +39,7 @@ function parse(parser, fieldPackets, typeCast, nestTables, connection) {
           : parser.parseLengthCodedString() );
     }
 
-    if (typeof nestTables == 'string' && nestTables.length) {
+    if (typeof nestTables === 'string' && nestTables.length) {
       this[fieldPacket.table + nestTables + fieldPacket.name] = value;
     } else if (nestTables) {
       this[fieldPacket.table] = this[fieldPacket.table] || {};
@@ -93,12 +93,12 @@ function typeCast(field, parser, timeZone, supportBigNumbers, bigNumberStrings,
     case Types.FLOAT:
     case Types.DOUBLE:
       numberString = parser.parseLengthCodedString();
-      return (numberString === null || (field.zeroFill && numberString[0] == '0'))
+      return (numberString === null || (field.zeroFill && numberString[0] === '0'))
         ? numberString : Number(numberString);
     case Types.NEWDECIMAL:
     case Types.LONGLONG:
       numberString = parser.parseLengthCodedString();
-      return (numberString === null || (field.zeroFill && numberString[0] == '0'))
+      return (numberString === null || (field.zeroFill && numberString[0] === '0'))
         ? numberString
         : ((supportBigNumbers && (bigNumberStrings || (Number(numberString) >= IEEE_754_BINARY_64_PRECISION) || Number(numberString) <= -IEEE_754_BINARY_64_PRECISION))
           ? numberString

test/unit/pool/test-destroy-connection.js

@@ -14,7 +14,7 @@ server.listen(common.fakeServerPort, function (err) {
     assert.strictEqual(connection, pool._allConnections[0]);
     connection.destroy();
 
-    assert.ok(pool._allConnections.length == 0);
+    assert.strictEqual(pool._allConnections.length, 0);
     assert.ok(!connection._pool);
 
     assert.doesNotThrow(function () { connection.release(); });