Get input image shape statically in the model construction function#101
Open
LucasMahieu wants to merge 2 commits intomystic123:masterfrom
Open
Get input image shape statically in the model construction function#101LucasMahieu wants to merge 2 commits intomystic123:masterfrom
LucasMahieu wants to merge 2 commits intomystic123:masterfrom
Conversation
Instead of using input.get_shape() fonction We can pass input image shape to yolo_v3 and yolo_v3_tiny constructor function. Since the input placeholder shape is statically defined (to None, size, size, 3) We can have access to this 'size' when constructing the yolo_v3 or yolo_v3_tiny models. This if more efficient for inference. This commit should not break any anterior codes since it is only adding 1 optional argument to model constructor functions
There was a bug in the way the all zero prediction was removed from the image_prediction tensor This solution is correct, much more simple and clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using input.get_shape() fonction
We can pass input image shape to yolo_v3 and yolo_v3_tiny constructor
function.
Since the input placeholder shape is statically defined (to None, size, size, 3)
We can have access to this 'size' when constructing the yolo_v3 or
yolo_v3_tiny models.
This if more efficient for inference.
This commit should not break any anterior codes since it is only adding
1 optional argument to model constructor functions