Draft
Conversation
…e, prettier) - Remove all configs except as needed to cover project-defined rules - Testing: Change from broken use of "category" to relying on custom `meta.version` for determination of ES version (eslint docs allowing for customization within `meta`) - Linting as per latest prettier - Update devDeps
Contributor
Author
|
Btw, while there were some other aspects of your config which might be of general interest, such as:
...I didn't add these as:
|
Contributor
Author
|
@mysticatea : Hi... Was just wondering if you were open in principle to this concept of a separate core plugin having the custom rules only (also asked for in #23) from which |
- Add coverage to ignore and lint all by default (adding to ignore allows discovery by IDEs)
Contributor
Author
|
I've published my own @brettz9/eslint-plugin which just extracts the bare rules (and the es5 and es6 configs), so if you aren't planning on developing this further on your own, you're of course welcome to close. |
MichaelDeBoey
added a commit
to MichaelDeBoey/eslint-plugin-mysticatea
that referenced
this pull request
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21 and #23
meta.versionfor determination of ES version (eslint docs allowing for customization withinmeta)Note that this is not a PR to be accepted here, but a PR to suggest a separate repository,
@mysticatea/eslint-plugin-core(or however you'd want to name it). That is why I've submitted it as a draft, but it should be ready for review.If you are amenable to setting up such a separate repository, e.g., with the contents of this PR, I could look to amending the current code of
@mysticatea/eslint-pluginproper to make use of this proposed@mysticatea/eslint-plugin-coreproject.