This repository was archived by the owner on Oct 8, 2019. It is now read-only.
Conversation
Contributor
|
thanks for your work. Is this test failure expected? |
Contributor
|
The related topic is #215. Could you let us know the hadoop policy of check styles? |
Contributor
Author
|
You can check Hadoop Coding Style here. |
Contributor
Author
|
The compile failure is caused since the version of checkstyle plugin only supports JDK8. Re-seinding PR soon to fix it. |
Contributor
|
okay, thanks. |
Signed-off-by: Tsuyoshi Ozawa <ozawa.tsuyoshi@gmail.com>
Contributor
|
I think we need to at least turn off check-style warning logs for |
Contributor
|
cc: @myui |
Owner
|
@oza Could you move this PR to https://github.com/apache/incubator-hivemall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables compile-time coding style check by using maven-checkstyle-plugin.
Please run:
and it shows you the warning and error messages, based on Google Java Coding Style in maven-checkstyle-plugin: http://checkstyle.sourceforge.net/google_style.html
https://google.github.io/styleguide/javaguide.html