Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new configuration option to make which action= requests are blocked for anonymous users configurable, replacing the previously hardcoded action=history restriction.
Changes:
- Add
CrawlerProtectedActionsconfig (default["history"]) and bump extension version to1.3.0. - Update
CrawlerProtectionService::checkPerformAction()to consult the configured protected actions via a newisProtectedAction()helper. - Extend unit tests to cover configured actions, empty configuration, and case-insensitive matching.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
includes/CrawlerProtectionService.php |
Introduces CrawlerProtectedActions option and action-matching helper used by checkPerformAction(). |
tests/phpunit/unit/CrawlerProtectionServiceTest.php |
Updates service construction and adds tests for configurable protected actions behavior. |
extension.json |
Registers CrawlerProtectedActions with default value and bumps extension version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14